From 77ab30d334a9c2251748a1dffb37ab97039cec84 Mon Sep 17 00:00:00 2001 From: Gaurav Sheni Date: Wed, 15 May 2024 16:47:14 -0400 Subject: [PATCH 1/7] Create install.yaml --- .github/workflows/install.yaml | 35 ++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 .github/workflows/install.yaml diff --git a/.github/workflows/install.yaml b/.github/workflows/install.yaml new file mode 100644 index 000000000..7c281c6c2 --- /dev/null +++ b/.github/workflows/install.yaml @@ -0,0 +1,35 @@ +name: Install Tests +on: + pull_request: + types: [opened, synchronize] + push: + branches: + - main +jobs: + install: + name: ${{ matrix.os }} - ${{ matrix.python_version }} install + strategy: + fail-fast: true + matrix: + os: [ubuntu-latest, macos-latest] + python_version: ["3.8", "3.12"] + runs-on: ${{ matrix.os }} + steps: + - name: Set up python ${{ matrix.python_version }} + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python_version }} + - uses: actions/checkout@v4 + - name: Build package + run: | + make package + - name: Install package + run: | + python -m pip install "unpacked_sdist/." + - name: Test by importing packages + run: | + python -c "import sdv" + python -c "import sdv;print(sdv.version.public)" + - name: Check package conflicts + run: | + python -m pip check From cde6640c831b37ccbefa639fcdeea1973a0658ff Mon Sep 17 00:00:00 2001 From: Gaurav Sheni Date: Wed, 15 May 2024 16:48:05 -0400 Subject: [PATCH 2/7] Update Makefile --- Makefile | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Makefile b/Makefile index ff5871ffa..f05d29561 100644 --- a/Makefile +++ b/Makefile @@ -267,3 +267,22 @@ release-major: check-release bumpversion-major release check-deps: $(eval allow_list='cloudpickle=|graphviz=|numpy=|pandas=|tqdm=|copulas=|ctgan=|deepecho=|rdt=|sdmetrics=|platformdirs=') pip freeze | grep -v "SDV.git" | grep -E $(allow_list) | sort > $(OUTPUT_FILEPATH) + +.PHONY: upgradepip +upgradepip: + python -m pip install --upgrade pip + +.PHONY: upgradebuild +upgradebuild: + python -m pip install --upgrade build + +.PHONY: upgradesetuptools +upgradesetuptools: + python -m pip install --upgrade setuptools + +.PHONY: package +package: upgradepip upgradebuild upgradesetuptools + python -m build ; \ + $(eval VERSION=$(shell python -c 'import setuptools; setuptools.setup()' --version)) + tar -zxvf "dist/sdv-${VERSION}.tar.gz" + mv "sdv-${VERSION}" unpacked_sdist From e7b01d98d0302fdb0c6eb7f4953deddc6242769f Mon Sep 17 00:00:00 2001 From: Gaurav Sheni Date: Wed, 15 May 2024 16:54:39 -0400 Subject: [PATCH 3/7] Update install.yaml --- .github/workflows/install.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/install.yaml b/.github/workflows/install.yaml index 7c281c6c2..3970f1b73 100644 --- a/.github/workflows/install.yaml +++ b/.github/workflows/install.yaml @@ -7,13 +7,12 @@ on: - main jobs: install: - name: ${{ matrix.os }} - ${{ matrix.python_version }} install + name: ${{ matrix.python_version }} install strategy: fail-fast: true matrix: - os: [ubuntu-latest, macos-latest] python_version: ["3.8", "3.12"] - runs-on: ${{ matrix.os }} + runs-on: ubuntu-latest steps: - name: Set up python ${{ matrix.python_version }} uses: actions/setup-python@v5 From c54552d2882051a1a4b56263d3c76396d080ea1c Mon Sep 17 00:00:00 2001 From: Gaurav Sheni Date: Wed, 15 May 2024 17:11:33 -0400 Subject: [PATCH 4/7] Update integration.yml --- .github/workflows/integration.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 3418bf2e7..717b7fa3a 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -9,6 +9,7 @@ jobs: integration: runs-on: ${{ matrix.os }} strategy: + fail-fast: true matrix: python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest, windows-latest] From 750a1825cd9818798b16f2e7856c741bfb4bd422 Mon Sep 17 00:00:00 2001 From: Gaurav Sheni Date: Wed, 15 May 2024 17:11:47 -0400 Subject: [PATCH 5/7] Update minimum.yml --- .github/workflows/minimum.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/minimum.yml b/.github/workflows/minimum.yml index f97dc4fbe..10ac72666 100644 --- a/.github/workflows/minimum.yml +++ b/.github/workflows/minimum.yml @@ -9,6 +9,7 @@ jobs: minimum: runs-on: ${{ matrix.os }} strategy: + fail-fast: true matrix: python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest, windows-latest] From 9c959df19fb53792eff85b0d6424bcc1d6ea9961 Mon Sep 17 00:00:00 2001 From: Gaurav Sheni Date: Wed, 15 May 2024 17:11:59 -0400 Subject: [PATCH 6/7] Update unit.yml --- .github/workflows/unit.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml index 870a0f28d..55883f20a 100644 --- a/.github/workflows/unit.yml +++ b/.github/workflows/unit.yml @@ -9,6 +9,7 @@ jobs: unit: runs-on: ${{ matrix.os }} strategy: + fail-fast: true matrix: python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest, windows-latest] From 20f21a55ef6b9723de358b45718e1713636b9951 Mon Sep 17 00:00:00 2001 From: gsheni Date: Wed, 15 May 2024 18:35:27 -0400 Subject: [PATCH 7/7] add pyyaml as dep --- Makefile | 2 +- pyproject.toml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f05d29561..5f1547db4 100644 --- a/Makefile +++ b/Makefile @@ -265,7 +265,7 @@ release-major: check-release bumpversion-major release .PHONY: check-deps check-deps: - $(eval allow_list='cloudpickle=|graphviz=|numpy=|pandas=|tqdm=|copulas=|ctgan=|deepecho=|rdt=|sdmetrics=|platformdirs=') + $(eval allow_list='cloudpickle=|graphviz=|numpy=|pandas=|tqdm=|copulas=|ctgan=|deepecho=|rdt=|sdmetrics=|platformdirs=|pyyaml=') pip freeze | grep -v "SDV.git" | grep -E $(allow_list) | sort > $(OUTPUT_FILEPATH) .PHONY: upgradepip diff --git a/pyproject.toml b/pyproject.toml index 900616666..91f25152b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -38,6 +38,7 @@ dependencies = [ 'rdt>=1.12.0', 'sdmetrics>=0.14.0', 'platformdirs>=4.0', + 'pyyaml>=6.0.1', ] [project.urls]