Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clipping during ClusterBasedNormalizer transform #699

Open
fealho opened this issue Aug 29, 2023 · 0 comments
Open

Remove clipping during ClusterBasedNormalizer transform #699

fealho opened this issue Aug 29, 2023 · 0 comments

Comments

@fealho
Copy link
Member

fealho commented Aug 29, 2023

Problem Description

The ClusterBasedNormalizer doesn't need to give a guarantee of values being between -1 and 1, so the clipping during the transform is unnecessary.

Expected behavior

Remove clipping during transform

RDT/rdt/transformers/numerical.py

Line 515 in 5d7f8b7

normalized = np.clip(normalized, -.99, .99)

Note: ensure this doesn't break CTGAN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fealho