Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FMPy support #4

Open
filokot opened this issue May 18, 2020 · 5 comments
Open

Add FMPy support #4

filokot opened this issue May 18, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@filokot
Copy link
Collaborator

filokot commented May 18, 2020

Add FMPy support: https://github.com/CATIA-Systems/FMPy/tree/master/fmpy

@AwhLorraine
Copy link

Hi
I try to add Fmpy (https://github.com/CATIA-Systems/FMPy/tree/master/fmpy) support to mshoot.
This is heavily inspired from the work in modestpy with Fmpy support (https://github.com/sdu-cfei/modest-py/blob/master/modestpy/fmi/model.py).

fmpy support.txt

Can you take a look at it? And send some feedback

Thanks

@filokot
Copy link
Collaborator Author

filokot commented Dec 31, 2020

Hi,

Thank you for your effort! I will be able to look at the code around Jan. 20 at the earliest. Hope that others can correspond though - I will let them know just in case they miss a notification

All the best.

@krzysztofarendt
Copy link
Member

Hello, I should be able to review the code within a week :)
Thank you for your contribution.

@AwhLorraine
Copy link

Great!
I was able to correct some mishapes in the code! You may review this version.
fmpy support.txt

HNY to all you by the way!

@krzysztofarendt
Copy link
Member

krzysztofarendt commented Jan 3, 2021

@AwhLorraine , could you please implement the proposed changes to your fork of mshoot and then create a pull request that we could review?

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

That would make the reviewing process a lot smoother.

Also, is it possible to check if https://github.com/sdu-cfei/mshoot/blob/master/test/test_fmi.py works?
If you're unsure how unit test works, you can leave this step to us.

Thanks!

@krzysztofarendt krzysztofarendt added enhancement New feature or request good first issue Good for newcomers labels Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants