Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking create offer repeatedly generates mutliple offers #1

Closed
Xoeseko opened this issue Nov 7, 2018 · 1 comment
Closed

Clicking create offer repeatedly generates mutliple offers #1

Xoeseko opened this issue Nov 7, 2018 · 1 comment

Comments

@Xoeseko
Copy link
Contributor

Xoeseko commented Nov 7, 2018

Hi,

I just realized that if a user gets impatient with the waiting for a buy offer to be generated (with slow internet for example) and clicks multiple times multiple offers are generated... It is of course still a prototype but I imagine this could be really dangerous in an actual production environment with real money at play.

Steps to reproduce :

  1. In auctions on the sdg market frontend
  2. "View actions" -> "Buying offers" -> "New purchase offer"
  3. Repeatedly click "Create Purchase offer"

Actual Results

Multiple purchase offers are saved for example.

Expected Results

Only one offer created even when multiple clicks or a possibility to delete offers

I was able to reproduce this but only at a smaller scale than the provided example. My network connection being slow at that moment certainly helped both generate frustration and allowed me to do multiple clicks before the offers were saved. I suspect this is the same for sale offers and other similar functionalities. Although I wasn't able to test that.

gilles-hemmerle added a commit that referenced this issue Mar 7, 2019
A security has been added on selling / buying and offer forms in the auction
@gilles-hemmerle
Copy link
Collaborator

This was fixed. Will install the new version in test server once all ticket will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants