From 6a29b6f76c47a4622b4ced8abb8867b4780dbf52 Mon Sep 17 00:00:00 2001 From: Nikola Nyagolov Date: Tue, 10 Dec 2024 08:51:26 +0200 Subject: [PATCH 1/2] Fixing issue https://github.com/sdatkinson/NeuralAmpModelerPlugin/issues/541 where NeuralAmpModelerPlugin causes plugin host(s) to crash and/or exit unexpectedly --- NeuralAmpModeler/NeuralAmpModelerControls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NeuralAmpModeler/NeuralAmpModelerControls.h b/NeuralAmpModeler/NeuralAmpModelerControls.h index f85db74c..f38c08d5 100644 --- a/NeuralAmpModeler/NeuralAmpModelerControls.h +++ b/NeuralAmpModeler/NeuralAmpModelerControls.h @@ -784,7 +784,7 @@ class NAMSettingsPageControl : public IContainerBaseWithNamedChildren { IControl::SetValueFromDelegate(normalizedValue, valIdx); const std::string s = ConvertToString(normalizedValue); - OnTextEntryCompletion(s.c_str(), valIdx); + SetStr(s.c_str()); }; private: From 1855cb84514719f1118da274d9c9cd13cdcfd168 Mon Sep 17 00:00:00 2001 From: Steven Atkinson Date: Thu, 19 Dec 2024 19:20:50 -0800 Subject: [PATCH 2/2] Update NeuralAmpModelerControls.h SetDirty(false); --- NeuralAmpModeler/NeuralAmpModelerControls.h | 1 + 1 file changed, 1 insertion(+) diff --git a/NeuralAmpModeler/NeuralAmpModelerControls.h b/NeuralAmpModeler/NeuralAmpModelerControls.h index f38c08d5..e62085aa 100644 --- a/NeuralAmpModeler/NeuralAmpModelerControls.h +++ b/NeuralAmpModeler/NeuralAmpModelerControls.h @@ -785,6 +785,7 @@ class NAMSettingsPageControl : public IContainerBaseWithNamedChildren IControl::SetValueFromDelegate(normalizedValue, valIdx); const std::string s = ConvertToString(normalizedValue); SetStr(s.c_str()); + SetDirty(false); }; private: