Upgrade mockito-core to 3.4.6 #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Static mocking would help with #323 . With that we should be able to control hostname resolution without providing custom DNS server. |
Upgrades mockito version. Version 3.4.6 was chosen because 3.4.0 is the first one providing mocking of static methods that we possibly want to use. Does not switch to mockito-inline yet.
Bouncheck
force-pushed
the
scylla-4.x-mockito-upgrade
branch
from
e4d4c43 to
542f539
Compare
|
It seems that micrometer tests break with the version upgrade. Switched version back to 2.28.2 for micrometer |
It looks like not only |
|
Let's drop it and do it on another occasion, it does not fit our purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades mockito version. Version 3.4.6 was chosen because 3.4.0 is the first one providing mocking of static methods that we possibly want to use. Does not switch to mockito-inline yet.