Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification of mudata.read and anndata.read #76

Open
MUCDK opened this issue Aug 26, 2024 · 4 comments
Open

Unification of mudata.read and anndata.read #76

MUCDK opened this issue Aug 26, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@MUCDK
Copy link

MUCDK commented Aug 26, 2024

First, I think documentation could be improved for such a basic function, second, I think it should take similar arguments to anndata.read.

@MUCDK MUCDK added the enhancement New feature or request label Aug 26, 2024
@gtca
Copy link
Collaborator

gtca commented Aug 29, 2024

Thanks, @MUCDK!

Which other arguments from anndata.read would you like to see here? Is it about propagating arguments like as_sparse, as_sparse_fmt, and chunk_size to the readers of individual modalities?

@selmanozleyen
Copy link
Member

@gtca I'd imagine adding the backup_url to be very useful. We currently are planning to use scanpy.readwrite._check_datafile_present_and_download to download MuData objects and read them but I think it makes more sense for this project to use the private functions of scanpy to load the MuData object.

@gtca
Copy link
Collaborator

gtca commented Sep 11, 2024

I don't think we should make MuData depend on scanpy though.
If we reuse scanpy.readwrite._check_datafile_present_and_download, would it make sense to have it in muon.read() instead?

@selmanozleyen
Copy link
Member

I don't think it matters which function we use as long as backup_url functionality is there and similar to scanpy in muon.read(). I didn't know muon didn't depend on scanpy so a re-implementation would make sense I guess. From what I saw it was a quite robust implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants