Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scully init ng-add schematic silently fails when there is invalid json in angular.json #1299

Closed
SanderElias opened this issue Mar 26, 2021 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@SanderElias
Copy link
Contributor

SanderElias commented Mar 26, 2021

🐞 Bug report

Description

As an example, when there is a trailing comma in one of the array's in angular.json the CLI will just work.
However, running ng add @scullyio/init will silently fail. It will exit without an error before its done.

@SanderElias SanderElias added the bug Something isn't working label Mar 26, 2021
@SanderElias
Copy link
Contributor Author

When you have this issue. I did explain how to do a manual installation here

@SanderElias SanderElias added the help wanted Extra attention is needed label Mar 26, 2021
@BenLune
Copy link

BenLune commented May 17, 2021

Thanks @SanderElias ,
I had the same kind of problem, but with an error, and not while the installation process. When running npm run scully, I had an error telling that Scully didn't find my project in the angular.json, but it was in. Thanks to this issue, I understood that the reason was a guilty comma in the angular.json file, then the JSON was invalid for Scully. After removing the comma, it was ok...
It's quite important to check if the angular.json file is valid when error or strange behaviour occurs.

@SanderElias
Copy link
Contributor Author

Related to #1402
I'm going to close this one, so we can concentrate discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants