Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release stable verison #6

Open
frisitano opened this issue Nov 19, 2024 · 2 comments
Open

Release stable verison #6

frisitano opened this issue Nov 19, 2024 · 2 comments

Comments

@frisitano
Copy link

Overview

Currently, downstream consumers of this library are referencing it via a git reference to the main branch. This is a fragile pattern and sensitive to logic drift and API changes of the library which could have a downstream impact. I propose we cut a stable release of this library by either creating a git tag or publishing the crate to crates.io. Publishing to crates.io would be the preferred option but may incur additional overhead. An alternative is that we could refer to a specific commit hash in downstream consumers but I believe this is bad practice.

@lispc
Copy link
Contributor

lispc commented Nov 19, 2024

sounds good.what about you first use cargo reference to a git rev inside reth, after hundreds of blocks verified (make sure no big issue, both in correctness and interface design), then we publish to crates.io?

@frisitano
Copy link
Author

That sounds reasonable to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants