fix: blockhash mismatch #913
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er fields file, verify its hash and download it. Also implement a Reader to read the file's format and provide the requested information to Manager
…tead of full requested bytes (65 in this case)
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| downloadCtx, downloadCtxCancel := context.WithTimeout(m.ctx, timeoutDownload) | ||
| defer downloadCtxCancel() | ||
|
|
||
| req, err := http.NewRequestWithContext(downloadCtx, http.MethodGet, m.downloadURL, nil) |
There was a problem hiding this comment.
Risk: Affected versions of golang.org/x/net, golang.org/x/net/http2, and net/http are vulnerable to Uncontrolled Resource Consumption. An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames.
Fix: Upgrade this library to at least version 0.23.0 at go-ethereum/go.mod:103.
Reference(s): GHSA-4v7x-pqxf-cx7m, CVE-2023-45288
Ignore this finding from ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2.…and use it to reconstruct correct block hashes
… before execution
jonastheis
changed the base branch from
feat/sync-directly-from-da
to
jt/execute-blocks-only-once
jonastheis
force-pushed
the
jt/execute-blocks-only-once
branch
from
38f46ed to
26dbf42
Compare
13 tasks
Base automatically changed from
jt/execute-blocks-only-once
to
feat/sync-directly-from-da
August 6, 2024 03:02
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
This PR fixes the problem of mismatching block hashes due to the missing header fields
difficultyandextraDatain DA. It should be reviewed in conjunction with #903, which provides a way to prepare this missing data and describes the format in more detail.Specifically, this PR implements a missing header fields manager that:
Tested on mainnet:
https://scrollscan.com/block/64500:
0xd229dc5edaebccff15987f42bb5c23060b3f0372251e19e843f1bb69742bfab12. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?