Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove interior mutability #94

Merged
merged 32 commits into from
Aug 5, 2024
Merged

feat: remove interior mutability #94

merged 32 commits into from
Aug 5, 2024

Conversation

iammadab
Copy link
Contributor

@iammadab iammadab commented Jul 30, 2024 •
edited
Loading

Removes interior mutability hack introduced in #80, and closes #87.

Also resolves the issue described in #86, see commit

iammadab added 30 commits July 30, 2024 10:27
@iammadab
define chip handler structure
2e4ed60
@iammadab
fix calldata chip
a6ff6b7
@iammadab
fix global state chip
0f36d54
@iammadab
fix memory chip
7c22fc4
@iammadab
fix uint arithmetic unit
d8630e5
@iammadab
fix range chip
8cbd98e
@iammadab
fix stack chip
c72ffb2
@iammadab
fix uint cmp
3b0b9a9
@iammadab
fix singer-utils chips
f4bd553
@iammadab
fix add instruction
47c75f6
@iammadab
fix calldata chip
99cd9f1
@iammadab
fix dup instruction
dfbcb21
@iammadab
fix jum and jumpdest
3c4d64f
@iammadab
fix jumpi instruction
14bd2ff
@iammadab
fix mstore + pop instruction
a79a4fd
@iammadab
fix push instruction
76e6eae
@iammadab
fix ret instruction
67a8502
@iammadab
fix swap instruction
ce597b9
@iammadab
fix pro add instruction
e6332a4
@iammadab
fix pro calldata instruction
6aa50ae
@iammadab
fix pro gt instruction
a409a32
@iammadab
fix jumpi inst pro
a578a92
@iammadab
fix pro mstore inst
20b7340
@iammadab
fix pro ret instruction
2cf46eb
@iammadab
fix bb_final
c2ee938
@iammadab
fix bb_ret
e90bf0b
@iammadab
fix bb_start
547dabf
@iammadab
fix gt inst
7657bd4
@iammadab
tests passing
a5d1feb
@iammadab
fix constant generation: use max_cell_bit instead of C for computations
c74e7d2
@iammadab iammadab marked this pull request as ready for review July 30, 2024 12:13
@iammadab iammadab requested review from dreamATD and hero78119 July 30, 2024 12:13
hero78119
hero78119 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the effort!

singer-utils/src/chips/bytecode.rs Outdated Show resolved Hide resolved
dreamATD
dreamATD approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@dreamATD dreamATD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge it after @iammadab fixes some small comments.

singer-utils/src/chip_handler.rs Outdated Show resolved Hide resolved
@iammadab iammadab mentioned this pull request Aug 5, 2024
Merged
@dreamATD dreamATD merged commit f5cd8b5 into feat/chip_handler_refactor Aug 5, 2024
3 of 4 checks passed
dreamATD pushed a commit that referenced this pull request Aug 7, 2024
@iammadab
feat: chip handler refactor (#80)
cfd717e 
* confirm const across file impl

* implement try from cell_id's to uint

* add test for uint from cell ids

* add documentation

* document N_OPERAND_CELLS constant

* wip

* test cell repacking

* add documentation

* update packing test, ensure remaining values are 0s

* add more uint instantiation methods

* add test placeholders

* sketch base plan for cmp

* implement and test pad cells

* modify from_range and from_bytes to use cell padding

* extract logic for uint from arbitrary cell_width to make from_range and from_bytes easier

* add compile time evaluated min function

* introduce new constant  cleans up uint_from*

* update uint from cell id test to test greater than N_OPERANDS

* add test for uint from different sized cells

* implement add_unsafe

* add functions sketch

* wip

* all func

* building

* test compiling

* use range checker

* refactor constants second pass

* document cmp

* wip

* arithmetic second pass

* delete old uint

* refactor arithmetic

* fix documentation

* add test for add

* test add constant unsafe

* add test for add_small_unsafe

* implement handle borrow

* test sub_unsafe

* rename add_small to add_cell

* wip

* change uint mod management

* setup structure for namespacing constants

* refactor counter vector implementation

* introduce difference

* define ram and rom structures

* potential bug

* rom phase 1

* rename

* implement oam handler phase 1

* implement ram handler phase 1

* bytecode chip attempt 1

* implement call data records builder p1

* implement global state chip record generator p1

* implement memory chip record generator

* implement stack chip record generator p1

* wip

* util method for cell to mixed

* start work on range chip

* wip

* document range check uint

* clean up range check uint

* remove range_chip_bit_width injection

* move non-zero

* add interior mutability to range chip

* add interior mutability to bytecode

* add interior mutability to call data chip

* add interior mutability to memory chip

* add interior mutability to stack

* ram handler using single source oam handler

* update signer utils

* big wip

* fix singer compile errors

* fix compile errors

* delete old chip handler

* cleanup

* merge oam handler with ram handler

* fmt

* remove random 7 comments

* feat: remove interior mutability (#94)

* define chip handler structure

* fix calldata chip

* fix global state chip

* fix memory chip

* fix uint arithmetic unit

* fix range chip

* fix stack chip

* fix uint cmp

* fix singer-utils chips

* fix add instruction

* fix calldata chip

* fix dup instruction

* fix jum and jumpdest

* fix jumpi instruction

* fix mstore + pop instruction

* fix push instruction

* fix ret instruction

* fix swap instruction

* fix pro add instruction

* fix pro calldata instruction

* fix pro gt instruction

* fix jumpi inst pro

* fix pro mstore inst

* fix pro ret instruction

* fix bb_final

* fix bb_ret

* fix bb_start

* fix gt inst

* tests passing

* fix constant generation: use max_cell_bit instead of C for computations

* cleanup

* resolve pr commenets
This was referenced Aug 7, 2024
Closed
Closed
yczhangsjtu pushed a commit that referenced this pull request Aug 12, 2024
@iammadab @yczhangsjtu
feat: chip handler refactor (#80)
3499a70 
* confirm const across file impl

* implement try from cell_id's to uint

* add test for uint from cell ids

* add documentation

* document N_OPERAND_CELLS constant

* wip

* test cell repacking

* add documentation

* update packing test, ensure remaining values are 0s

* add more uint instantiation methods

* add test placeholders

* sketch base plan for cmp

* implement and test pad cells

* modify from_range and from_bytes to use cell padding

* extract logic for uint from arbitrary cell_width to make from_range and from_bytes easier

* add compile time evaluated min function

* introduce new constant  cleans up uint_from*

* update uint from cell id test to test greater than N_OPERANDS

* add test for uint from different sized cells

* implement add_unsafe

* add functions sketch

* wip

* all func

* building

* test compiling

* use range checker

* refactor constants second pass

* document cmp

* wip

* arithmetic second pass

* delete old uint

* refactor arithmetic

* fix documentation

* add test for add

* test add constant unsafe

* add test for add_small_unsafe

* implement handle borrow

* test sub_unsafe

* rename add_small to add_cell

* wip

* change uint mod management

* setup structure for namespacing constants

* refactor counter vector implementation

* introduce difference

* define ram and rom structures

* potential bug

* rom phase 1

* rename

* implement oam handler phase 1

* implement ram handler phase 1

* bytecode chip attempt 1

* implement call data records builder p1

* implement global state chip record generator p1

* implement memory chip record generator

* implement stack chip record generator p1

* wip

* util method for cell to mixed

* start work on range chip

* wip

* document range check uint

* clean up range check uint

* remove range_chip_bit_width injection

* move non-zero

* add interior mutability to range chip

* add interior mutability to bytecode

* add interior mutability to call data chip

* add interior mutability to memory chip

* add interior mutability to stack

* ram handler using single source oam handler

* update signer utils

* big wip

* fix singer compile errors

* fix compile errors

* delete old chip handler

* cleanup

* merge oam handler with ram handler

* fmt

* remove random 7 comments

* feat: remove interior mutability (#94)

* define chip handler structure

* fix calldata chip

* fix global state chip

* fix memory chip

* fix uint arithmetic unit

* fix range chip

* fix stack chip

* fix uint cmp

* fix singer-utils chips

* fix add instruction

* fix calldata chip

* fix dup instruction

* fix jum and jumpdest

* fix jumpi instruction

* fix mstore + pop instruction

* fix push instruction

* fix ret instruction

* fix swap instruction

* fix pro add instruction

* fix pro calldata instruction

* fix pro gt instruction

* fix jumpi inst pro

* fix pro mstore inst

* fix pro ret instruction

* fix bb_final

* fix bb_ret

* fix bb_start

* fix gt inst

* tests passing

* fix constant generation: use max_cell_bit instead of C for computations

* cleanup

* resolve pr commenets
hero78119 pushed a commit that referenced this pull request Sep 30, 2024
@iammadab @hero78119
feat: chip handler refactor (#80)
812f87c 
* confirm const across file impl

* implement try from cell_id's to uint

* add test for uint from cell ids

* add documentation

* document N_OPERAND_CELLS constant

* wip

* test cell repacking

* add documentation

* update packing test, ensure remaining values are 0s

* add more uint instantiation methods

* add test placeholders

* sketch base plan for cmp

* implement and test pad cells

* modify from_range and from_bytes to use cell padding

* extract logic for uint from arbitrary cell_width to make from_range and from_bytes easier

* add compile time evaluated min function

* introduce new constant  cleans up uint_from*

* update uint from cell id test to test greater than N_OPERANDS

* add test for uint from different sized cells

* implement add_unsafe

* add functions sketch

* wip

* all func

* building

* test compiling

* use range checker

* refactor constants second pass

* document cmp

* wip

* arithmetic second pass

* delete old uint

* refactor arithmetic

* fix documentation

* add test for add

* test add constant unsafe

* add test for add_small_unsafe

* implement handle borrow

* test sub_unsafe

* rename add_small to add_cell

* wip

* change uint mod management

* setup structure for namespacing constants

* refactor counter vector implementation

* introduce difference

* define ram and rom structures

* potential bug

* rom phase 1

* rename

* implement oam handler phase 1

* implement ram handler phase 1

* bytecode chip attempt 1

* implement call data records builder p1

* implement global state chip record generator p1

* implement memory chip record generator

* implement stack chip record generator p1

* wip

* util method for cell to mixed

* start work on range chip

* wip

* document range check uint

* clean up range check uint

* remove range_chip_bit_width injection

* move non-zero

* add interior mutability to range chip

* add interior mutability to bytecode

* add interior mutability to call data chip

* add interior mutability to memory chip

* add interior mutability to stack

* ram handler using single source oam handler

* update signer utils

* big wip

* fix singer compile errors

* fix compile errors

* delete old chip handler

* cleanup

* merge oam handler with ram handler

* fmt

* remove random 7 comments

* feat: remove interior mutability (#94)

* define chip handler structure

* fix calldata chip

* fix global state chip

* fix memory chip

* fix uint arithmetic unit

* fix range chip

* fix stack chip

* fix uint cmp

* fix singer-utils chips

* fix add instruction

* fix calldata chip

* fix dup instruction

* fix jum and jumpdest

* fix jumpi instruction

* fix mstore + pop instruction

* fix push instruction

* fix ret instruction

* fix swap instruction

* fix pro add instruction

* fix pro calldata instruction

* fix pro gt instruction

* fix jumpi inst pro

* fix pro mstore inst

* fix pro ret instruction

* fix bb_final

* fix bb_ret

* fix bb_start

* fix gt inst

* tests passing

* fix constant generation: use max_cell_bit instead of C for computations

* cleanup

* resolve pr commenets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamATD dreamATD dreamATD approved these changes

@hero78119 hero78119 hero78119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iammadab @hero78119 @dreamATD