Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPCS: Rename CommitmentWithData to CommitmentWithWitness & remove unnecessary trait requirement. #745

Merged
merged 3 commits into from
Dec 13, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove the comm-with-wit serialize requirement
yczhangsjtu committed Dec 13, 2024
commit 8d12ca59d5a844dfe7445958d328b96215601a6d
3 changes: 1 addition & 2 deletions mpcs/src/basefold/structure.rs
Original file line number Diff line number Diff line change
@@ -58,8 +58,7 @@ pub struct BasefoldVerifierParams<E: ExtensionField, Spec: BasefoldSpec<E>> {

/// A polynomial commitment together with all the data (e.g., the codeword, and Merkle tree)
/// used to generate this commitment and for assistant in opening
#[derive(Clone, Debug, Default, Serialize, Deserialize)]
#[serde(bound(serialize = "E: Serialize", deserialize = "E: DeserializeOwned"))]
#[derive(Clone, Debug, Default)]
pub struct BasefoldCommitmentWithWitness<E: ExtensionField>
where
E::BaseField: Serialize + DeserializeOwned,
2 changes: 1 addition & 1 deletion mpcs/src/lib.rs
Original file line number Diff line number Diff line change
@@ -113,7 +113,7 @@ pub trait PolynomialCommitmentScheme<E: ExtensionField>: Clone + Debug {
type Param: Clone + Debug + Serialize + DeserializeOwned;
type ProverParam: Clone + Debug + Serialize + DeserializeOwned;
type VerifierParam: Clone + Debug + Serialize + DeserializeOwned;
type CommitmentWithWitness: Clone + Debug + Default + Serialize + DeserializeOwned;
type CommitmentWithWitness: Clone + Debug + Default;
type Commitment: Clone + Debug + Default + Serialize + DeserializeOwned;
type CommitmentChunk: Clone + Debug + Default;
type Proof: Clone + Debug + Serialize + DeserializeOwned;