-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cargo build
work
#719
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…n' into matthias/integration-test-are-busted
…ation-test-are-busted
@@ -32,13 +32,6 @@ jobs: | |||
timeout-minutes: 30 | |||
runs-on: [self-hosted, Linux, X64] | |||
|
|||
strategy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our strategy matrix only has one entry. So we might as well not bother.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted into #725
key: integration-${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} | ||
- uses: dtolnay/rust-toolchain@nightly | ||
|
||
- name: Run example | ||
env: | ||
RAYON_NUM_THREADS: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't read anywhere.
Right now a simple
cargo build
fails. So let's fix that.This PR also disentangles
ceno_rt
, so that we can work on building guest programs much easier.Update: I extracted the remove of the target matrix into #725 for ease of review.