Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cargo build work #719

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Make cargo build work #719

wants to merge 24 commits into from

Conversation

matthiasgoergens
Copy link
Collaborator

@matthiasgoergens matthiasgoergens commented Dec 10, 2024

Right now a simple cargo build fails. So let's fix that.

This PR also disentangles ceno_rt, so that we can work on building guest programs much easier.

Update: I extracted the remove of the target matrix into #725 for ease of review.

@matthiasgoergens

This comment was marked as outdated.

@@ -32,13 +32,6 @@ jobs:
timeout-minutes: 30
runs-on: [self-hosted, Linux, X64]

strategy:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our strategy matrix only has one entry. So we might as well not bother.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted into #725

key: integration-${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
- uses: dtolnay/rust-toolchain@nightly

- name: Run example
env:
RAYON_NUM_THREADS: 2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't read anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants