Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable debug assertions in integration tests #714

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

matthiasgoergens
Copy link
Collaborator

@matthiasgoergens matthiasgoergens commented Dec 9, 2024

To catch some bugs, like the recent breakage.

@matthiasgoergens matthiasgoergens force-pushed the matthias/integration-test-are-busted branch from 6ede26e to cf62f50 Compare December 9, 2024 10:41
@matthiasgoergens
Copy link
Collaborator Author

238516f / #692 seems to be the first bad commit that fails with:

$ RUST_BACKTRACE=1 cargo run --package ceno_zkvm --example riscv_opcodes -- --start 10 --end 11
    Finished `dev` profile [optimized + debuginfo] target(s) in 0.05s
     Running `target/debug/examples/riscv_opcodes --start 10 --end 11`
thread 'main' panicked at ff_ext/src/lib.rs:53:13:
assertion `left == right` failed
  left: 8
 right: 2
stack backtrace:
   0: rust_begin_unwind
             at /rustc/c94848c046d29f9a80c09aae758e27e418a289f2/library/std/src/panicking.rs:681:5
   1: core::panicking::panic_fmt
             at /rustc/c94848c046d29f9a80c09aae758e27e418a289f2/library/core/src/panicking.rs:75:14
   2: core::panicking::assert_failed_inner
   3: core::panicking::assert_failed
             at /rustc/c94848c046d29f9a80c09aae758e27e418a289f2/library/core/src/panicking.rs:364:5
   4: ff_ext::impl_goldilocks::<impl ff_ext::ExtensionField for goldilocks::structs::GoldilocksExt2>::from_bases
             at ./ff_ext/src/lib.rs:53:13
   5: <transcript::basic::BasicTranscript<E> as transcript::Transcript<E>>::read_challenge
             at ./transcript/src/basic.rs:35:17
   6: ceno_zkvm::scheme::prover::ZKVMProver<E,PCS>::create_proof
             at ./ceno_zkvm/src/scheme/prover.rs:125:13
   7: riscv_opcodes::main
             at ./ceno_zkvm/examples/riscv_opcodes.rs:304:30
   8: core::ops::function::FnOnce::call_once
             at /home/matthias/.rustup/toolchains/nightly-2024-12-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@matthiasgoergens matthiasgoergens changed the title Check: integration tests are busted? Enabled debug assertions in integration tests Dec 10, 2024
@matthiasgoergens matthiasgoergens changed the title Enabled debug assertions in integration tests Enable debug assertions in integration tests Dec 10, 2024
@matthiasgoergens matthiasgoergens enabled auto-merge (squash) December 10, 2024 05:32
@matthiasgoergens matthiasgoergens merged commit 33901fd into master Dec 10, 2024
6 checks passed
@matthiasgoergens matthiasgoergens deleted the matthias/integration-test-are-busted branch December 10, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants