Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/transcript fork #224

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Fix/transcript fork #224

merged 2 commits into from
Sep 14, 2024

Conversation

naure
Copy link
Collaborator

@naure naure commented Sep 14, 2024

This is another approach to #223, fixing #222 / #210. Features:

  • Prepare for parallel proving with independent transcripts per thread.
  • Soundness with different transcripts in each thread.
  • Type-safe API which captures the transcript by value.

There is no function to merge the threads back into one transcript, but that can be added if ever needed.

@naure naure force-pushed the fix/transcript_fork branch from 37396e2 to 1305107 Compare September 14, 2024 09:46
Copy link
Collaborator

@kunxian-xia kunxian-xia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunxian-xia kunxian-xia merged commit c9f6ba1 into master Sep 14, 2024
6 checks passed
@kunxian-xia kunxian-xia deleted the fix/transcript_fork branch September 14, 2024 10:20
hero78119 pushed a commit that referenced this pull request Sep 30, 2024
This is another approach to #223, fixing #222 / #210. Features:

- Prepare for parallel proving with independent transcripts per thread.
- Soundness with different transcripts in each thread.
- Type-safe API which captures the transcript by value.

There is no function to merge the threads back into one transcript, but
that can be added if ever needed.

---------

Co-authored-by: Aurélien Nicolas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants