Feat: witness should be basefield elements #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #181 also covered this change :) |
hero78119
approved these changes
Sep 5, 2024
|
This is also a blocker to #188. 😢 |
kunxian-xia
added a commit
that referenced
this pull request
Sep 6, 2024
- Partially address issue #174 - fix under constraints - optimized constriants register read constraints check - address the discussion in #173 (comment) to support overflow/underflow arithmetics due to wrapping_add/sub in revm - `MockProver` move to test scope and load u16 table > Later we need to optimize and support table reuse across unittest to reduce overhead. cc @zemse :) - ~~all witness assignment use base field instead of ext field~~ done by #192 --------- Co-authored-by: kunxian xia <[email protected]>
hero78119
pushed a commit
that referenced
this pull request
Sep 30, 2024
The matrix for holding circuit witness should over base field instead of extension field. This can save proving time when the prover infers each record's MLE as `E x B` is much faster than `E x E`.
hero78119
added a commit
that referenced
this pull request
Sep 30, 2024
- Partially address issue #174 - fix under constraints - optimized constriants register read constraints check - address the discussion in #173 (comment) to support overflow/underflow arithmetics due to wrapping_add/sub in revm - `MockProver` move to test scope and load u16 table > Later we need to optimize and support table reuse across unittest to reduce overhead. cc @zemse :) - ~~all witness assignment use base field instead of ext field~~ done by #192 --------- Co-authored-by: kunxian xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matrix for holding circuit witness should over base field instead of extension field. This can save proving time when the prover infers each record's MLE as
E x Bis much faster thanE x E.