Skip to content

Commit

Permalink
some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
noel2004 committed Dec 10, 2024
1 parent bc58d3d commit a211aad
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions transcript/src/basic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ impl<E: ExtensionField> Transcript<E> for BasicTranscript<E> {
}

fn read_challenge(&mut self) -> Challenge<E> {
// notice `from_bases` and `from_limbs` has the same behavior but
// `from_bases` has a sanity check for length of input slices
// while `from_limbs` use the first two fields silently
// we select `from_base` here to make it being more clear that
// we only use the first 2 fields here to construct the
// extension field (i.e. the challenge)
let r = E::from_bases(&self.permutation.squeeze()[..2]);

Challenge { elements: r }
Expand Down

0 comments on commit a211aad

Please sign in to comment.