Skip to content

Commit

Permalink
Merge branch 'master' into bg/div-rem-remu-opcodes
Browse files Browse the repository at this point in the history
  • Loading branch information
Bryan Gillespie committed Dec 7, 2024
2 parents 4c11b43 + e23de25 commit 277fd77
Show file tree
Hide file tree
Showing 9 changed files with 26 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
components: rustfmt, clippy
targets: riscv32im-unknown-none-elf
# TODO(Matthias): see whether we can keep this in sync with rust-toolchain.toml automatically?
toolchain: nightly-2024-10-03
toolchain: nightly-2024-12-06
- name: Cargo cache
uses: actions/cache@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
with:
targets: riscv32im-unknown-none-elf
# TODO(Matthias): see whether we can keep this in sync with rust-toolchain.toml automatically?
toolchain: nightly-2024-10-03
toolchain: nightly-2024-12-06
- name: Cargo cache
uses: actions/cache@v3
with:
Expand Down
33 changes: 16 additions & 17 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ceno_emul/src/addr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ impl IterAddresses for Range<Addr> {
}
}

impl<'a, T: GetAddr> IterAddresses for &'a [T] {
impl<T: GetAddr> IterAddresses for &[T] {
fn iter_addresses(&self) -> impl ExactSizeIterator<Item = Addr> {
self.iter().map(T::get_addr)
}
Expand Down
2 changes: 1 addition & 1 deletion ceno_zkvm/src/chip_handler/global_state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::{

use super::GlobalStateRegisterMachineChipOperations;

impl<'a, E: ExtensionField> GlobalStateRegisterMachineChipOperations<E> for CircuitBuilder<'a, E> {
impl<E: ExtensionField> GlobalStateRegisterMachineChipOperations<E> for CircuitBuilder<'_, E> {
fn state_in(&mut self, pc: Expression<E>, ts: Expression<E>) -> Result<(), ZKVMError> {
let record: Vec<Expression<E>> = vec![
Expression::Constant(E::BaseField::from(RAMType::GlobalState as u64)),
Expand Down
4 changes: 2 additions & 2 deletions ceno_zkvm/src/chip_handler/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ use crate::{
};
use ff_ext::ExtensionField;

impl<'a, E: ExtensionField, NR: Into<String>, N: FnOnce() -> NR> MemoryChipOperations<E, NR, N>
for CircuitBuilder<'a, E>
impl<E: ExtensionField, NR: Into<String>, N: FnOnce() -> NR> MemoryChipOperations<E, NR, N>
for CircuitBuilder<'_, E>
{
fn memory_read(
&mut self,
Expand Down
4 changes: 2 additions & 2 deletions ceno_zkvm/src/chip_handler/register.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ use crate::{

use super::{RegisterChipOperations, RegisterExpr};

impl<'a, E: ExtensionField, NR: Into<String>, N: FnOnce() -> NR> RegisterChipOperations<E, NR, N>
for CircuitBuilder<'a, E>
impl<E: ExtensionField, NR: Into<String>, N: FnOnce() -> NR> RegisterChipOperations<E, NR, N>
for CircuitBuilder<'_, E>
{
fn register_read(
&mut self,
Expand Down
2 changes: 1 addition & 1 deletion ceno_zkvm/src/chip_handler/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pub enum DebugIndex {
RdWrite = 0,
}

impl<'a, E: ExtensionField> CircuitBuilder<'a, E> {
impl<E: ExtensionField> CircuitBuilder<'_, E> {
pub fn register_debug_expr<T: Into<usize>>(&mut self, debug_index: T, expr: Expression<E>) {
self.cs.register_debug_expr(debug_index, expr)
}
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[toolchain]
channel = "nightly-2024-10-03"
channel = "nightly-2024-12-06"

0 comments on commit 277fd77

Please sign in to comment.