New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary base64 decoding #230

Open

kmike opened this issue Oct 31, 2024 · 0 comments

Member

kmike commented Oct 31, 2024

It seems the library decodes httpResponseBody from base64 multiple times:

First, when detecting the response type:

scrapy-zyte-api/scrapy_zyte_api/responses.py

Line 197 in 1269ebb

body=b64decode(api_response["httpResponseBody"]), # type: ignore
And then when the response is created:

scrapy-zyte-api/scrapy_zyte_api/responses.py

Line 127 in 1269ebb

body = b64decode(api_response["httpResponseBody"])

or

scrapy-zyte-api/scrapy_zyte_api/responses.py

Line 154 in 1269ebb

body=b64decode(api_response.get("httpResponseBody") or ""),

This looks like a potentially costly operation; it'd be great to optimize it, so that the decoding only happens once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment