Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error on unsuccesful automation #119

Open
fgregg opened this issue Aug 7, 2023 · 1 comment · May be fixed by #157
Open

Raise error on unsuccesful automation #119

fgregg opened this issue Aug 7, 2023 · 1 comment · May be fixed by #157

Comments

@fgregg
Copy link

fgregg commented Aug 7, 2023

When doing a browser automation that is not successful, it would be really helpful to either raise an error, change the status code from 200 to something more indicative of an error, or both.

@Gallaecio
Copy link
Contributor

Gallaecio commented Aug 7, 2023

You can do it through a relatively simple downloader middleware, and I don’t think it makes sense as a default, so I am not sure if there is much to do here. Maybe document it along with #118? And it would also cover #120.

@Gallaecio Gallaecio linked a pull request Dec 29, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants