Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Python 3.13 (latest version) in tox.ini #66

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

mohsinsurani
Copy link
Contributor

digit_group_separator and price is not none - make sured to make all the test passed.

digit_group_separator and price is not none - make sured to make all the test passed.
@Gallaecio
Copy link
Member

We should add support for all other Python versions in between.

@mohsinsurani
Copy link
Contributor Author

Thanks. I added Support for different versions of python

@Gallaecio
Copy link
Member

Minor thing: could you remove the spaces after the comma? For consistency with other projects.

@mohsinsurani
Copy link
Contributor Author

No worries. I removed spaces.

@Gallaecio
Copy link
Member

Thanks.

I think the only things left are to update these accordingly:

@mohsinsurani
Copy link
Contributor Author

Thanks. I updated the code. Do I require to change for mypy?

@Gallaecio
Copy link
Member

Gallaecio commented Oct 22, 2024

Do I require to change for mypy?

Great point. It should indeed run with the latest Python version ideally.

@mohsinsurani
Copy link
Contributor Author

Thanks, I made the changes.

@Gallaecio
Copy link
Member

https://github.com/scrapinghub/price-parser/pull/66/files#r1810447696 is not addressed yet. It’s empty space in line 40 of the new code.

Remove space

Co-authored-by: Adrián Chaves <[email protected]>
@mohsinsurani
Copy link
Contributor Author

Sorry, I missed it. I committed this change.

@Gallaecio
Copy link
Member

I’ve just realized that I recently lost admin access to the repo 🤦

As soon as I get it back I’ll approve the CI run, and merge if all goes well. Thanks!

@Gallaecio
Copy link
Member

OK, the only failing issue is due to 3.6 not being available in CI. We can handle dropping end-of-life Python versions in a separate PR later on. Thank you!

@Gallaecio Gallaecio merged commit 9e06e1c into scrapinghub:master Oct 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants