-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Python 3.13 (latest version) in tox.ini #66
Conversation
digit_group_separator and price is not none - make sured to make all the test passed.
We should add support for all other Python versions in between. |
Thanks. I added Support for different versions of python |
Minor thing: could you remove the spaces after the comma? For consistency with other projects. |
No worries. I removed spaces. |
Thanks. I think the only things left are to update these accordingly:
|
Thanks. I updated the code. Do I require to change for mypy? |
Great point. It should indeed run with the latest Python version ideally. |
Thanks, I made the changes. |
https://github.com/scrapinghub/price-parser/pull/66/files#r1810447696 is not addressed yet. It’s empty space in line 40 of the new code. |
Remove space Co-authored-by: Adrián Chaves <[email protected]>
Sorry, I missed it. I committed this change. |
I’ve just realized that I recently lost admin access to the repo 🤦 As soon as I get it back I’ll approve the CI run, and merge if all goes well. Thanks! |
OK, the only failing issue is due to 3.6 not being available in CI. We can handle dropping end-of-life Python versions in a separate PR later on. Thank you! |
digit_group_separator and price is not none - make sured to make all the test passed.