Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update response parsing to correlate using request_id #88

Open
ghost opened this issue Jan 6, 2020 · 0 comments
Open

Update response parsing to correlate using request_id #88

ghost opened this issue Jan 6, 2020 · 0 comments
Labels
core-agent protocol protocol implementation/work required quick tech-debt

Comments

@ghost
Copy link

ghost commented Jan 6, 2020

Before the merge of the PR putting request_id's into responses, the connection pool was necessary to ensure correlatable requests & responses (by making a new socket connection for every request) -- now that we have the request IDs we can greatly simplify the correlation logic.

Whether to pool or not (or restrict the pool to some small limit) is up for discussion.

@ghost ghost added quick core-agent protocol protocol implementation/work required tech-debt labels Jan 6, 2020
@ghost ghost self-assigned this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-agent protocol protocol implementation/work required quick tech-debt
Projects
None yet
Development

No branches or pull requests

0 participants