You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
P2: if anyone want to tackle this would take to master, but not a top issue. Would need to be behind a config flag ZS_LOG_UPSTREAM_ERRORS which still would default off.
Why I don't think this is on by default:
Logs could be filled with non-exceptional errors. Ignoring bad URLs is the right thing, some users could send thousands, polluting the log with errors that don't need to be addressed
the URLs can contain access keys (examples: S3 access keys as query string param, I used with a system with 256 bit keys in URL). We shouldn't assume the logging platform is setup for "secrets", and getting this should be opt in.
These lines silently ignore URLs that can't be retrieved:
zipstreamer/zip_streamer/zip_streamer.go
Lines 37 to 44 in ebcdb42
The text was updated successfully, but these errors were encountered: