Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Add password validation in frontend #139

Open
sachinsom93 opened this issue Mar 2, 2021 · 3 comments
Open

[Frontend] Add password validation in frontend #139

sachinsom93 opened this issue Mar 2, 2021 · 3 comments

Comments

@sachinsom93
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Password strength validation should be added while creating users to enhance the security.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
I'll soon submit a PR for it

@amlannandy
Copy link
Contributor

@sachinsom93 Hey! Have you checked #125 and #126 ? I don't think we need to check the password strength on both the frontend and backend. The login functionality is already set in the frontend in such a way that it'll show whatever error the server sends. So this might be kinda redundant.

@sachinsom93
Copy link
Collaborator Author

Thanks for your response @amlannandy , but the login functionality only show the error after sending a wrong request to server, by providing password validation at frontend we can provide instant feedback to user at the time of his typing, don't you think it would increase user experience ?

@amlannandy
Copy link
Contributor

@sachinsom93 Okay for instant feedback this does sound good. Just wanted to make sure you're aware of the PR. Carry on :) 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants