Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload unification & upgrades #159

Closed
7 tasks done
gsfr opened this issue Feb 11, 2016 · 9 comments
Closed
7 tasks done

Upload unification & upgrades #159

gsfr opened this issue Feb 11, 2016 · 9 comments

Comments

@gsfr
Copy link
Member

gsfr commented Feb 11, 2016

Edited by @kofalt - itemized list:

  1. Lay initial groundwork for upload unification. (@kofalt)
  2. EnginePlacer is written but needs to be rigged up and connected to the endpoint. (@nagem)
  3. LabelPlacer and (new) UidPlacer should replace most logic currently in upload.reaper and upload.uploader. (@rentzso)
  4. After that is complete, consider unifying the LabelPlacer & UidPlacer. (@gsfr)
  5. Generate closures for on-the-fly processing; performance optimization. (@kofalt)
  6. Once all the above is complete, consider input schema unification(@gsfr)
  7. Once all the above is complete, consider Placer naming changes (@kofalt)
@kofalt kofalt self-assigned this Feb 19, 2016
@kofalt kofalt changed the title Unify all upload endpoints Upload unification & upgrades Mar 2, 2016
@kofalt kofalt removed their assignment Mar 2, 2016
@kofalt kofalt added this to the Bali 2 milestone Mar 2, 2016
@kofalt kofalt self-assigned this Mar 2, 2016
@kofalt kofalt removed this from the Bali 2 milestone Mar 7, 2016
@kofalt
Copy link
Contributor

kofalt commented Apr 21, 2016

It's my understanding that the UIDPlacer and LabelPlacer are complete, ticking that box. The code basically is unified right now via subclassing, so ticking that box. We punted on closure generation, and naming turned out to be fine, so ticking those boxes. Editing final placer box to be unassigned. Moving ticket back to @gsfr for prioritization of the last items :)

@gsfr
Copy link
Member Author

gsfr commented Jul 6, 2016

Let's talk about schema unification at standup tomorrow. I'd also love to finally get rid of the schema composition loopback shenanigans.

@nagem
Copy link
Contributor

nagem commented Jul 7, 2016

While working on #360, I noticed that upload.reaper is still there. Has the reaper been updated to use either the label or UID endpoint, and if so, can this be removed? @gsfr @rentzso

@gsfr
Copy link
Member Author

gsfr commented Jul 8, 2016

Yes, we only use /upload/uid and /upload/label.

@kofalt
Copy link
Contributor

kofalt commented Jul 28, 2016

Can we close this given that @nagem is working on jinja stuff, which will probably handle dedup?

@gsfr
Copy link
Member Author

gsfr commented Jul 29, 2016

Let's reserve @nagem the gratification of closing this from her anticipated jinja PR.

@gsfr gsfr assigned nagem and unassigned gsfr Jul 29, 2016
@nagem
Copy link
Contributor

nagem commented Aug 17, 2016

How do we feel about "input schema unification" after #406?

@gsfr
Copy link
Member Author

gsfr commented Aug 17, 2016

Keeping this open per offline discussion with @nagem.

@nagem
Copy link
Contributor

nagem commented Jul 13, 2017

Input schema has been considered, keeping separate is the best option available.

@nagem nagem closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants