From 47bbfc42e3cca60ce8c754101f65e722f57e29c5 Mon Sep 17 00:00:00 2001 From: Jordi Subira Nieto Date: Tue, 14 May 2024 14:06:48 +0200 Subject: [PATCH] add comment for snet.Dial --- pkg/snet/snet.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/snet/snet.go b/pkg/snet/snet.go index 8e4a53d83b..89dce7bdd1 100644 --- a/pkg/snet/snet.go +++ b/pkg/snet/snet.go @@ -135,6 +135,9 @@ func (n *SCIONNetwork) OpenRaw(ctx context.Context, addr *net.UDPAddr) (PacketCo // connection. func (n *SCIONNetwork) Dial(ctx context.Context, network string, listen *net.UDPAddr, remote *UDPAddr) (*Conn, error) { + // XXX(JordiSubira): Currently Dial does not check that received packets are + // originated from the expected remote address. This should be adapted to + // check that the remote packets are originated from the expected remote address. metrics.CounterInc(n.Metrics.Dials) if network != "udp" {