-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with Alpha filtration #14
Comments
Hello Kiran,
Thank you so much for your interest, and my apologies for the trouble! I
just got hit with the beginning of the semester, but we will get to the
bottom of this. I will just need about a week to really do it justice.
It's great that you attached the example...that will really help.
Thank you for your patience, and talk soon
-Chris
…On Thu, Jan 23, 2020 at 6:00 PM Kiran Vaddi ***@***.***> wrote:
Hey,
First of all, thanks for a great package. I find all of the scikit-tda
packages really useful.
I'm trying to compute Alpha filtration of a 3-dimensional data (attached
as a text file) and I get the following error(but return an empty
persistence diagram)
I couldn't find enough resources online as to why this can be the case.
Any help on this would be greatly appreciated.
Doing spatial.Delaunay triangulation...
Finished spatial.Delaunay triangulation (Elapsed Time 0.00938)
Building alpha filtration...
Finished building alpha filtration (Elapsed Time 4.01)
Constructing boundary matrix...
Error: Not a proper filtration: [107 111 207] added before (107, 111)
Computing persistence pairs...
Finished computing persistence pairs (Elapsed Time 9.16e-05)
points.txt
<https://github.com/scikit-tda/cechmate/files/4105989/points.txt>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#14?email_source=notifications&email_token=AAJWDZSHU4MGF7OIB7QRAR3Q7IOSFA5CNFSM4KK6LJFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIMKWLQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJWDZWGHBNBAPJIIL236QLQ7IOSFANCNFSM4KK6LJFA>
.
|
Oh, and if in the meantime you still want to do alpha, you should check out
GUDHI
http://gudhi.gforge.inria.fr/doc/latest/group__alpha__complex.html
It's a great library, though it's a bit harder to install for Python. So
that was the motivation behind me making cechmate
On Fri, Jan 24, 2020 at 5:12 PM Christopher Tralie <
[email protected]> wrote:
… Hello Kiran,
Thank you so much for your interest, and my apologies for the trouble! I
just got hit with the beginning of the semester, but we will get to the
bottom of this. I will just need about a week to really do it justice.
It's great that you attached the example...that will really help.
Thank you for your patience, and talk soon
-Chris
On Thu, Jan 23, 2020 at 6:00 PM Kiran Vaddi ***@***.***>
wrote:
> Hey,
> First of all, thanks for a great package. I find all of the scikit-tda
> packages really useful.
> I'm trying to compute Alpha filtration of a 3-dimensional data (attached
> as a text file) and I get the following error(but return an empty
> persistence diagram)
> I couldn't find enough resources online as to why this can be the case.
> Any help on this would be greatly appreciated.
>
> Doing spatial.Delaunay triangulation...
> Finished spatial.Delaunay triangulation (Elapsed Time 0.00938)
> Building alpha filtration...
> Finished building alpha filtration (Elapsed Time 4.01)
> Constructing boundary matrix...
> Error: Not a proper filtration: [107 111 207] added before (107, 111)
> Computing persistence pairs...
> Finished computing persistence pairs (Elapsed Time 9.16e-05)
>
> points.txt
> <https://github.com/scikit-tda/cechmate/files/4105989/points.txt>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#14?email_source=notifications&email_token=AAJWDZSHU4MGF7OIB7QRAR3Q7IOSFA5CNFSM4KK6LJFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIMKWLQ>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJWDZWGHBNBAPJIIL236QLQ7IOSFANCNFSM4KK6LJFA>
> .
>
|
Hello @kiranvad, First of all, I found a bug with the simplex condition (which was the first problem you noticed)/ But also, it's more and more clear that the points you provided are not in general position. I verified that a lot of the tetrahedra it tries to add into the filtration are numerically flat. Here's one, for example: Bearing this in mind, I did a few things to improve numerical precision. The biggest help was to normalize the simplices before computing the circumcenter, and then to scale back at the end cechmate/cechmate/filtrations/alpha.py Line 162 in 255eec0
I also avoid adding a simplex if it's numerically flat after this normalization. Here's what happens for slightly perturbed points (same as before) Here's the result for both of the libraries now (notice how cechmate is not crashing anymore Zooming in, though, there's a problem I didn't notice before with GUDHI, and there's a different problem with cechmate I still want to leave this issue open, though, because there are definitely more elegant ways of dealing with this. I want to see if I can use "Simulations of Simplicity" when computing circumradii, which is a more systematic way of perturbing points with theoretical guarantees |
Hi Chris, |
I'm glad that at least gives a temporary solution while we work out a more
stable one.
…On Sun, Jul 26, 2020 at 6:55 PM Kiran Vaddi ***@***.***> wrote:
Hi Chris,
Thanks a lot for your response. This is really helpful.
It is interesting that it adds flat tetrahedron simplices although the
point cloud I had this issue with has a nice geometric structure to it.
Perturbing points makes sense for the data I was using for this work.
That's a physically meaningful solution.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJWDZV6CC73KRAZWWHQP4LR5SX4JANCNFSM4KK6LJFA>
.
|
Hey,
First of all, thanks for a great package. I find all of the scikit-tda packages really useful.
I'm trying to compute Alpha filtration of a 3-dimensional data (attached as a text file) and I get the following error(but return an empty persistence diagram)
I couldn't find enough resources online as to why this can be the case.
Any help on this would be greatly appreciated.
points.txt
The text was updated successfully, but these errors were encountered: