Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified way to pass uproot options for filtering the reading of branches (filter_name, ...) in dask and non-dask mode for nanoevents #973

Open
nikoladze opened this issue Dec 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nikoladze
Copy link
Contributor

nikoladze commented Dec 19, 2023

Currently we can pass options for filtering the reading of branches to uproot in dask mode via the uproot_options argument. That works because they are passed to uproot.dask. In non-dask mode it doesn't because uproot options are passed to uproot.open here. It might work via iteritems_options, but then one needs to know all the internals to figure this out ... I wonder if we can have a unified way to do this for dask and non-dask mode, although i don't have a very clear idea how to best do it (without manually putting in all possible uproot options and then deciding internally which ones to pass in where)

Related: usatlas/analysisbase-dask#4 (comment)

@nikoladze nikoladze added the enhancement New feature or request label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant