From e05512e79f28123c573dc97e5038a8491cd9a3ea Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Thu, 28 Mar 2024 01:10:31 -0400 Subject: [PATCH] fix: a few mistakes Signed-off-by: Henry Schreiner --- .github/workflows/tests.yml | 4 ++-- CMakeLists.txt | 2 +- pyproject.toml | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 901f236a..31bb4778 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -19,7 +19,7 @@ jobs: clang-tidy: name: Clang-Tidy runs-on: ubuntu-latest - container: silkeh/clang:15-bullseye + container: silkeh/clang:18-bookworm steps: - name: Install requirements @@ -31,7 +31,7 @@ jobs: submodules: true - name: Install extra requirements - run: python3 -m pip install setuptools_scm + run: python3 -m pip install setuptools_scm --break-system-packages - name: Configure run: cmake -S . -B build -DCMAKE_CXX_CLANG_TIDY="$(which clang-tidy);--warnings-as-errors=*" diff --git a/CMakeLists.txt b/CMakeLists.txt index f413198a..e57ac23e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -65,7 +65,7 @@ file(GLOB_RECURSE BOOST_HIST_PY_HEADERS "include/bh_python/*.hpp") file(GLOB BOOST_HIST_PY_SRC CONFIGURE_DEPENDS src/*.cpp) # This is the Python module -pybind11_add_module(_core SHARED ${BOOST_HIST_PY_HEADERS} ${BOOST_HIST_PY_SRC} ${BOOST_HIST_FILES}) +pybind11_add_module(_core MODULE ${BOOST_HIST_PY_HEADERS} ${BOOST_HIST_PY_SRC} ${BOOST_HIST_FILES}) # Add the include directory for boost/histogram/python target_include_directories(_core PRIVATE include) diff --git a/pyproject.toml b/pyproject.toml index 016ec4d6..30e76062 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -46,8 +46,7 @@ classifiers = [ "Typing :: Typed", ] dependencies = [ - "numpy;python_version<'3.12'", - "numpy>=1.26.0b1;python_version>='3.12'", + "numpy", "typing-extensions;python_version<'3.8'", ]