Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API for adversarial method #272

Open
tgnassou opened this issue Nov 4, 2024 · 1 comment
Open

Change API for adversarial method #272

tgnassou opened this issue Nov 4, 2024 · 1 comment

Comments

@tgnassou
Copy link
Collaborator

tgnassou commented Nov 4, 2024

For now, the domain classifier is initialized in the DomainAwareModule. This leads to an unclear setup for new users because someone who wants to avoid adversarial can have to deal with domain classifiers.

The goal would be to put the domain classifier in the adversarial losses. The domain output will be computed in the loss, and only adversarial methods will deal with the domain classifiers.

@ambroiseodt
Copy link
Contributor

@tgnassou do you have a detailed list of changes you want to implement there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants