Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Reva REST API call status codes correctly. #56

Open
MahdiBaghbani opened this issue Sep 26, 2023 · 0 comments
Open

Handle Reva REST API call status codes correctly. #56

MahdiBaghbani opened this issue Sep 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MahdiBaghbani
Copy link
Member

Currently we don't check the status codes of calling the Reva APIs, example:

public function generateTokenFromReva(string $userId, string $recipient)
{
// TODO: @Mahdi: handle failures in this request.
$tokenFromReva = $this->revaGet('sciencemesh/generate-invite', $userId, array('recipient' => $recipient));
error_log('Got token from reva!' . $tokenFromReva);
return json_decode($tokenFromReva, true);
}

Proper handling and throwing exceptions / or informing user about problem is required.

@MahdiBaghbani MahdiBaghbani added the bug Something isn't working label Sep 26, 2023
@MahdiBaghbani MahdiBaghbani added this to the Release 0.6 milestone Sep 26, 2023
@MahdiBaghbani MahdiBaghbani self-assigned this Sep 26, 2023
@glpatcern glpatcern modified the milestones: Release 0.6, Release 1.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants