Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move as much JS as possible from sprockets to vite #1889

Merged
merged 11 commits into from
Oct 20, 2022
Merged

Move as much JS as possible from sprockets to vite #1889

merged 11 commits into from
Oct 20, 2022

Commits on Oct 18, 2022

  1. move jquery and popper to be loaded via vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    f14c37c View commit details
    Browse the repository at this point in the history

  2. move bootstrap JS to vite from sprockets

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c041a6c View commit details
    Browse the repository at this point in the history

  3. move rails-ujs from sprockets to vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    a267d0c View commit details
    Browse the repository at this point in the history

  4. move cocoon JS over to vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    9574f6e View commit details
    Browse the repository at this point in the history

  5. avoid browse_everything doing a double-include of bootstrap

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    a4165f9 View commit details
    Browse the repository at this point in the history

  6. update comment header in sprockets application.js, for move to vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    467c54d View commit details
    Browse the repository at this point in the history

  7. remove actioncable from sprockets entirely 

    Don't move it over to vite. We weren't using it. if we ever want to use it, we'll have to figure out how to add it back in via vite
    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    973c6c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Move browse_everything sprockets JS to admin layout only 

    With weird workaround to prevent Blacklight sprockets-included JS from triggering strict mode, which breaks current version of blacklight_range_limit JS
    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    83810f1 View commit details
    Browse the repository at this point in the history

  2. have vite/rollup chunk video.js separately

    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    4b55c69 View commit details
    Browse the repository at this point in the history

  3. enable source maps in dev autoBuild 

    Unclear exactly what default is or how to turn off in prod. ElMassimo/vite_ruby#285
    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a329f42 View commit details
    Browse the repository at this point in the history

  4. update README for moving most JS to vite -- but not yet blacklight

    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    1a68fc4 View commit details
    Browse the repository at this point in the history