Make parallel merge even more robust #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a combination of current PID and worker id to create a unique file identifier.
|
Thanks a lot for this improvement - very much appreciated! Sorry that it took so long to merge. |
|
No worries, thanks for maintaining this very helpful package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
my previous change made it possible to use
merge_pdfsin parallel with several Julia worker threads working in parallel.However, what if you are running Julia processes in parallel with one thread each? Then the previous addition with
myid()won't help. So I added another identifier based on the PID of the Julia process (getpid()).I hope this should now cover all cases:
I admit I haven't tested the last point though.