Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tmp files for every process/worker #6

Closed
wants to merge 2 commits into from

Conversation

zauster
Copy link

@zauster zauster commented May 25, 2023

Hey,

very helpful package!

I run simulations in Julia and use PDFmerger.jl to create multi-page PDFs with descriptive statistics of the simulation. I tried now to run several simulations on different processes/workers, which, however, resulted in errors in the appendPDF! function. It seems that the multiple processes are interfering with the temporary files of other processes.

So I created a quick fix in that the temporary files now have a identifier of the process that created them. I tested the change locally with my simulation with multiple processes and the fix seems to work fine.
The unit tests pass fine.

Cheers,

Oliver

PS: I also fixed some typos in the other commit.

@zauster zauster mentioned this pull request May 25, 2023
@scheidan
Copy link
Owner

Great idea!
After I made a veritable mess with the merging I added your changes manually. I've mentioned your contribution in the Readme.

@scheidan scheidan closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants