Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last node in color map is always black #750

Open
moreApi opened this issue May 8, 2024 · 4 comments
Open

Last node in color map is always black #750

moreApi opened this issue May 8, 2024 · 4 comments

Comments

@moreApi
Copy link
Member

moreApi commented May 8, 2024

as seen for example here:

#757

java_t13jR7HcXm

@odinsbane
Copy link

@moreApi Your example is missing. I seem to be having an issue where textures turn black. If I select a new colormap it will briefly show color, then turn black again. Maybe it is related?

@smlpt
Copy link
Contributor

smlpt commented May 28, 2024

@odinsbane the volume turning black is likely caused by this bug, for me it happens as soon as I hover over the color map editor.

@odinsbane
Copy link

Exactly. That is the issue I am having. I don't know if it is related to this issue.

@odinsbane
Copy link

This error is caused by Colormap#sample

val bufferPosition: Float = position.coerceIn(0.0f, 1.0f) * width

Indexes are 0 based so they should go from 0 to width - 1. This is 0 to width, but since the Colormap can have multiple bands it wraps back to the next band... which is black again.

odinsbane pushed a commit to odinsbane/scenery that referenced this issue May 30, 2024
with odd h values. Issue scenerygraphics#750

Made a hot fix for generating an image form the ColormapEditor the image
was only halfdrawn. Issue scenerygraphics#757
skalarproduktraum pushed a commit that referenced this issue Aug 7, 2024
with odd h values. Issue #750

Made a hot fix for generating an image form the ColormapEditor the image
was only halfdrawn. Issue #757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants