Fix/SK-1178 | Set client_id in ModelRequest + single hearbeat function #739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short
Below are the key changes:
gRPC Connection Enhancements:
fedn/network/clients/grpc_handler.py
).Refactoring:
_init_secure_channel
and_init_insecure_channel
methods to use the newGRPC_OPTIONS
for connection settings (fedn/network/clients/grpc_handler.py
). [1] [2]heartbeat
method and updated thesend_heartbeats
method to utilize this new method (fedn/network/clients/grpc_handler.py
).Bug Fixes:
name
toclient_id
inget_model_from_combiner
andDownload
methods to accurately reflect the sender's client ID (fedn/network/clients/grpc_handler.py
,fedn/network/combiner/modelservice.py
). [1] [2]