Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/SK-1178 | Set client_id in ModelRequest + single hearbeat function #739

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented Nov 5, 2024

Short

  • Use client_id for the client id instead of setting "name" to be the id.
  • Add single hearbeat function for easier testing.

Below are the key changes:

gRPC Connection Enhancements:

  • Added keepalive settings and gRPC options to ensure the connection remains open for long-lived clients (fedn/network/clients/grpc_handler.py).

Refactoring:

  • Refactored the _init_secure_channel and _init_insecure_channel methods to use the new GRPC_OPTIONS for connection settings (fedn/network/clients/grpc_handler.py). [1] [2]
  • Extracted the heartbeat logic into a separate heartbeat method and updated the send_heartbeats method to utilize this new method (fedn/network/clients/grpc_handler.py).

Bug Fixes:

  • Corrected the attribute name from name to client_id in get_model_from_combiner and Download methods to accurately reflect the sender's client ID (fedn/network/clients/grpc_handler.py, fedn/network/combiner/modelservice.py). [1] [2]

@Wrede Wrede changed the title Fix/SK-1178 | Set client_id in ModelRequest Fix/SK-1178 | Set client_id in ModelRequest + single hearbeat function Nov 5, 2024
@Wrede Wrede requested a review from benjaminastrand November 6, 2024 10:08
@Wrede Wrede merged commit 60926be into master Nov 7, 2024
19 checks passed
@Wrede Wrede deleted the fix/SK-1176 branch November 7, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants