Feature/SK-946 | Add functionality for user defined server-functions #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrede
reviewed
Sep 2, 2024
fedn/network/api/client.py
Outdated
| @@ -574,6 +574,7 @@ def start_session( | |||
| helper: str = "", | |||
| min_clients: int = 1, | |||
| requested_clients: int = 8, | |||
| function_provider_path: str = None, | |||
There was a problem hiding this comment.
can't we have the FunctionProvider class as argument instead?
There was a problem hiding this comment.
That would be better since then the abstract class would prevent wrong structure on the class already at the API level. But I'm not sure what will happened with imports when the class gets stringified.. I'll investigate it :)
viktorvaladi
changed the title
Wrede
approved these changes
Oct 31, 2024
fedn/network/api/interface.py
Outdated
| @@ -940,6 +945,7 @@ def start_session( | |||
| helper="", | |||
| min_clients=1, | |||
| requested_clients=8, | |||
| function_provider=None, | |||
| print(f"Epoch {e}/{epochs-1} | Batch: {b}/{n_batches-1} | Loss: {loss.item()}") | ||
|
|
||
| # Metadata needed for aggregation server side | ||
| metadata = { |
There was a problem hiding this comment.
the naming of metadata now becomes confusing, should we call them aggregator_metadata vs model_metadata, or maybe in_metadata vs out_metadata?
| self.name = "custom" | ||
| self.code_set = False | ||
|
|
||
| def get_model_metadata(self): |
There was a problem hiding this comment.
this I don't understand why it's in the aggregator? Why not include model_metadata as an arg in APIClient.start_session()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality for user-defined aggregation, client selection, and client config. Also creates a new "update_handler" where some code from the aggregator and roundhandler relating to updates are moved.
Adds a new option to the start_session() CLI command:
client.start_session(server_functions=ServerFunctions)
User-defined code will be run in the new hook container
One simple example that highlights the new functionalities. See examples/server-functions/server_functions.py