Feature/SK-911 | Add terminate session to controller #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in progress |
ahellander
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Looks like a good start. But I think we will need to think carefully about UX. When terminated on controller, the combiner and clients will still be busy and new sessions will thus be delayed. This won't be the behavior a user expects. I think it would be better if the termination happened at the end of a completed round, and before a new round is started.
niklastheman
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminate an ongoing session when status is "Terminated". Obs, won't flush queues at combiners or terminate ongoing training or validation requests at clients.
requests.patch("http://localhost:8092/api/v1/sessions/b9fa1b07-fef9-4ddf-a869-a1d43f3c9968", json={"status": "Terminated"})