Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro annotations with explicitly provided type arguments don't expand #2

Closed
xeno-by opened this issue Aug 30, 2013 · 8 comments
Closed

Comments

@xeno-by
Copy link
Member

xeno-by commented Aug 30, 2013

aztek/scala-workflow#2 (comment)

stanch added a commit to stanch/paradise that referenced this issue Sep 3, 2013
@stanch
Copy link
Contributor

stanch commented Sep 3, 2013

@xeno-by, this seems to work for me, but looking how complex everything around is, maybe you should do a sanity check :)

stanch added a commit to stanch/paradise that referenced this issue Sep 3, 2013
stanch added a commit to stanch/paradise that referenced this issue Sep 4, 2013
@stanch
Copy link
Contributor

stanch commented Sep 4, 2013

The tests pass, however in console:

scala> @shove[Double] val superpower = 41.999
<console>:5: error: value superpower is not a member of object $iw
  lazy val $result = `superpower`
                                                   ^
<console>:10: error: value superpower is not a member of object $iw
 + "superpower: <notype> = " + scala.runtime.ScalaRunTime.replStringOf(`superpower`, 1000)
                                                                                                     ^

Hmmm?

@xeno-by
Copy link
Member Author

xeno-by commented Sep 4, 2013

Macro annotations never worked in repl.

@stanch
Copy link
Contributor

stanch commented Sep 4, 2013

Am I spoiled?

[info] Starting scala interpreter...
[info]
import workflow._
import Shortcuts._
Welcome to Scala version 2.10.3-RC1 (Java HotSpot(TM) 64-Bit Server VM, Java 1.6.0_45).
Type in expressions to have them evaluated.
Type :help for more information.

scala> @opt val x = Some(4) * 2 - Some(5)
x: Option[Int] = Some(3)

@xeno-by
Copy link
Member Author

xeno-by commented Sep 5, 2013

I mean they will expand just fine, but it's that newly generated members won't be found by repl, and I'm not yet sure how to remedy that.

@xeno-by
Copy link
Member Author

xeno-by commented Sep 5, 2013

Btw do you have an actual pull request? Can't find anything to merge. This is just an issue discussion, not a pull request discussion.

@stanch
Copy link
Contributor

stanch commented Sep 5, 2013

Btw do you have an actual pull request? Can't find anything to merge. This is just an issue discussion, not a pull request discussion.

Sure, I’ll submit one now. Just wanted to make sure that the REPL thing is not something extraordinary before that.

xeno-by added a commit that referenced this issue Sep 6, 2013
Expand macro annotations with explicitly provided type arguments (#2)
@stanch
Copy link
Contributor

stanch commented Sep 6, 2013

I think we can close this now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants