Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix match error in keyword completions #22138

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix match error in keyword completions #22138

merged 1 commit into from
Dec 4, 2024

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek requested a review from rochala December 4, 2024 15:08
rochala
rochala approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@rochala rochala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, how did we end up with this code in the first place ?

Shouldn't we get A match may not be exhaustive ?

@tgodzik tgodzik merged commit a67dbb0 into scala:main Dec 4, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochala rochala rochala approved these changes

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completions not shown after a method call with a polymorphic function literal
3 participants
@kasiaMarek @tgodzik @rochala