Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade REPL to use JLine 3.25.x #12933

Closed
SethTisue opened this issue Jan 22, 2024 · 4 comments · Fixed by scala/scala#10717
Closed

Upgrade REPL to use JLine 3.25.x #12933

SethTisue opened this issue Jan 22, 2024 · 4 comments · Fixed by scala/scala#10717
Assignees
@SethTisue
Labels
repl
Milestone
2.13.14

Comments

@SethTisue
Copy link
Member

SethTisue commented Jan 22, 2024 •
edited
Loading

https://github.com/jline/jline3/releases/tag/jline-parent-3.25.0

I'm not comfortable taking the upgrade so close to 2.13.13 release time, but let's take it for 2.13.14.

(and I should check Scala 3 too)
@SethTisue SethTisue added the repl label Jan 22, 2024
@SethTisue SethTisue added this to the 2.13.14 milestone Jan 22, 2024
@SethTisue SethTisue self-assigned this Jan 22, 2024
@lrytz
Copy link
Member

lrytz commented Jan 22, 2024 •
edited
Loading

Merge Jansi library into JLine by @gnodet in jline/jline3#871

Need to check if that comes with a change to released artifacts that we have to adapt to.

@SethTisue
Copy link
Member Author

3.25.1 is out: https://github.com/jline/jline3/releases/tag/jline-parent-3.25.1

But I'd still be more comfortable waiting for 2.13.14.

@SethTisue SethTisue changed the title Upgrade REPL to use JLine 3.25.0 Upgrade REPL to use JLine 3.25.x Jan 30, 2024
@SethTisue
Copy link
Member Author

Need to check if that comes with a change to released artifacts that we have to adapt to

I think not, since we're using the JLine uber-jar.

@SethTisue
Copy link
Member Author

needed to fix #12957

This was referenced Mar 14, 2024
Closed
Merged
@SethTisue SethTisue removed the blocker label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
repl
Projects
None yet
Milestone
2.13.14
Development

Successfully merging a pull request may close this issue.

REPL: Upgrade to JLine 3.25.1 (was 3.24.1) SethTisue/scala
2 participants
@lrytz @SethTisue