You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We want to refactor our button and link components.
For this a base class should be created for button components and a separate one for link components. These should be created in src/components/core/common-behaviors. The base classes should include basic styles needed for every button or link (e.g. cursor, outline, display). This should be considered case by case if it makes sense.
With this we will split each current action elements into two components:
Where necessary, create a common directory next to the components directory (e.g. src/components/button/{button,link,common}) for styles or common functionality (e.g. functions or mixins).
Avoid duplicating styles by using the possibility of adding an array of style objects to the custom element class.
kyubisation
changed the title
refactor: Refactor LinkButtonProperties to be a class and make all components that currently implement the interface extend it
refactor: Refactor LinkButtonProperties to be two base classes and make all components that currently implement the interface extend it
Dec 14, 2023
We want to refactor our button and link components.
For this a base class should be created for button components and a separate one for link components. These should be created in
src/components/core/common-behaviors
. The base classes should include basic styles needed for every button or link (e.g. cursor, outline, display). This should be considered case by case if it makes sense.With this we will split each current action elements into two components:
<sbb-button>
=><sbb-button>
+<sbb-button-link>
<sbb-link>
=><sbb-link>
+<sbb-link-button>
<sbb-card-action>
=><sbb-card-button>
+<sbb-card-link>
<sbb-header-action>
=><sbb-header-button>
+<sbb-header-link>
<sbb-menu-action>
=><sbb-menu-button>
+<sbb-menu-link>
<sbb-navigation-action>
=><sbb-navigation-button>
+<sbb-navigation-link>
Where necessary, create a common directory next to the components directory (e.g.
src/components/button/{button,link,common}
) for styles or common functionality (e.g. functions or mixins).Avoid duplicating styles by using the possibility of adding an array of style objects to the custom element class.
The text was updated successfully, but these errors were encountered: