From b1a332ed3b2b8a2c5d1640e178f449889ec5685b Mon Sep 17 00:00:00 2001
From: Jeremias Peier <jeremias.peier@sbb.ch>
Date: Thu, 21 Nov 2024 16:29:43 +0100
Subject: [PATCH] fix: fix review

---
 src/elements/select/readme.md | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/elements/select/readme.md b/src/elements/select/readme.md
index 6d437305a4..8d50c861d8 100644
--- a/src/elements/select/readme.md
+++ b/src/elements/select/readme.md
@@ -77,7 +77,7 @@ The component has no `size` property but, when slotted in a `sbb-form-field`, it
 ```html
 <sbb-form-field size="s">
   <label>Train types</label>
-  <sbb-select> ... </sbb-select>
+  <sbb-select>...</sbb-select>
 </sbb-form-field>
 ```
 
@@ -90,12 +90,27 @@ Additionally `sbb-option` will emit `optionSelected` when selected via user inte
 ## Accessibility
 
 The select follows the combobox pattern. As a technical difficulty, we have to copy the combobox element into the light DOM.
-As a consequence, linking labels is not fully supported. While `aria-label`, `aria-labelledby` and `aria-describedby` on the `sbb-select` works,
+As a consequence, linking labels is not fully supported. While `aria-label`, `aria-labelledby` and `aria-describedby` on the `sbb-select` work,
 using `<label>` together with `sbb-select` is only partially supported.
 As workaround, we copy the text into the aria-label of the combobox element, but this remains not synchronized.
 Whenever a `<label>` gets a change, we won't be able to detect it, and we won't be able to update the `aria-label`.
 The only two exceptions are when `connectedCallback()` gets called and when the document language changes.
 
+Fully supported:
+
+```html
+<sbb-select aria-label="Select train type">...</sbb-select>
+```
+
+Changes to the `<label>`-text might not be reflected after initialization:
+
+```html
+<sbb-form-field size="s">
+  <label>Train types</label>
+  <sbb-select>...</sbb-select>
+</sbb-form-field>
+```
+
 ## Keyboard interaction
 
 Closed panel, `sbb-select` has focus: