From 37a411b81b7c85f56721b780f37451ef0901c722 Mon Sep 17 00:00:00 2001 From: Jeremias Peier Date: Thu, 21 Nov 2024 08:17:40 +0100 Subject: [PATCH] fix: remove unused async modifier on willUpdate --- src/elements/checkbox/checkbox-panel/checkbox-panel.ts | 2 +- src/elements/checkbox/common/checkbox-common.ts | 2 +- src/elements/core/mixins/required-mixin.ts | 2 +- .../radio-button/radio-button-panel/radio-button-panel.ts | 2 +- src/elements/toggle-check/toggle-check.ts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/elements/checkbox/checkbox-panel/checkbox-panel.ts b/src/elements/checkbox/checkbox-panel/checkbox-panel.ts index 43abf00d6d..c59c514fde 100644 --- a/src/elements/checkbox/checkbox-panel/checkbox-panel.ts +++ b/src/elements/checkbox/checkbox-panel/checkbox-panel.ts @@ -73,7 +73,7 @@ class SbbCheckboxPanelElement extends SbbPanelMixin( { bubbles: true }, ); - protected override async willUpdate(changedProperties: PropertyValues): Promise { + protected override willUpdate(changedProperties: PropertyValues): void { super.willUpdate(changedProperties); if (changedProperties.has('checked')) { diff --git a/src/elements/checkbox/common/checkbox-common.ts b/src/elements/checkbox/common/checkbox-common.ts index 4cff2b464c..8f1c3e5fb2 100644 --- a/src/elements/checkbox/common/checkbox-common.ts +++ b/src/elements/checkbox/common/checkbox-common.ts @@ -49,7 +49,7 @@ export const SbbCheckboxCommonElementMixin = > ['disabled', 'required', 'size'].forEach((p) => this.requestUpdate(p)); } - protected override async willUpdate(changedProperties: PropertyValues): Promise { + protected override willUpdate(changedProperties: PropertyValues): void { super.willUpdate(changedProperties); if (changedProperties.has('checked') || changedProperties.has('indeterminate')) { diff --git a/src/elements/core/mixins/required-mixin.ts b/src/elements/core/mixins/required-mixin.ts index 3d82b98f0c..2cbb687bd6 100644 --- a/src/elements/core/mixins/required-mixin.ts +++ b/src/elements/core/mixins/required-mixin.ts @@ -32,7 +32,7 @@ export const SbbRequiredMixin = < } private _required: boolean = false; - protected override async willUpdate(changedProperties: PropertyValues): Promise { + protected override willUpdate(changedProperties: PropertyValues): void { super.willUpdate(changedProperties); if (changedProperties.has('required')) { diff --git a/src/elements/radio-button/radio-button-panel/radio-button-panel.ts b/src/elements/radio-button/radio-button-panel/radio-button-panel.ts index a68c565acf..bd6ec1b224 100644 --- a/src/elements/radio-button/radio-button-panel/radio-button-panel.ts +++ b/src/elements/radio-button/radio-button-panel/radio-button-panel.ts @@ -60,7 +60,7 @@ class SbbRadioButtonPanelElement extends SbbPanelMixin( this._hasSelectionExpansionPanelElement = !!this.closest?.('sbb-selection-expansion-panel'); } - protected override async willUpdate(changedProperties: PropertyValues): Promise { + protected override willUpdate(changedProperties: PropertyValues): void { super.willUpdate(changedProperties); if (changedProperties.has('checked')) { diff --git a/src/elements/toggle-check/toggle-check.ts b/src/elements/toggle-check/toggle-check.ts index 21382b758e..85b0e81c12 100644 --- a/src/elements/toggle-check/toggle-check.ts +++ b/src/elements/toggle-check/toggle-check.ts @@ -38,7 +38,7 @@ class SbbToggleCheckElement extends SbbFormAssociatedCheckboxMixin(SbbIconNameMi @property({ attribute: 'label-position', reflect: true }) public accessor labelPosition: 'before' | 'after' = 'after'; - protected override async willUpdate(changedProperties: PropertyValues): Promise { + protected override willUpdate(changedProperties: PropertyValues): void { super.willUpdate(changedProperties); if (changedProperties.has('checked')) {