-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source.dynamic errors quit the process instead of falling back / despite using mksafe() #4159
Comments
Hi @danbo ! Do you have logs of your issue? Also, I just pushed some changes related to Thanks! |
Tried the new version, still an issue
Telnet:
Logs:
|
@toots: Still an issue with Now, it doesn't exist with the errors above, but if I switch enough times between stream 1 and stream 2, I get a seg fault. The first time it was after 5-6 switches back and forth, the second time it was after like 15-20. First time:
Second time:
|
Description
Hi, so I'm getting similar issues to #3338 but worse with source.dynamic - despite using mksafe, the process quits. When stop using source.dynamic and just use the source directly, switching between stations / urls does have an assertion failed but does end up switching stations correctly.
I thought the recent rewrite of source.dynamic as part of #4156 might fix the issue but it did not.
The errors depend on what operators you use on top of the source you're feeding source.dynamic and whether or not they are soft (fallback works) or hard - process quits. (ie Assertion Failed or Source created multiple tracks in a single frame!, I even got a seg fault once or twice but maybe I'm not using something correctly).
metadata.map() makes the process quit for sure after switch stations once or twice.
This the sample I created to test - you can open up http://localhost:11111/telnet from the web console and switch between stations with
s 1
ands 2
a couple of times to see it quit the process.Steps to reproduce
Expected behavior
Any issues with the dynamic source should fall back / respect mksafe() / not quit the process
Liquidsoap version
Liquidsoap build config
Installation method
From official container image
Additional Info
Related to #3338
The text was updated successfully, but these errors were encountered: