Dynamic Text Issue with video.add_text.ffmpeg.raw.filter() #3554
bradenfallon
started this conversation in
User Support
Replies: 3 comments 16 replies
-
|
Hi @bradenfallon, Also |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
@vitoyucepi I'm a bit surprised by this error, we never use this parameter: @bradenfallon the reload mechanism is tricky with fffmpeg filters. You need to trigger the reload manually to trigger a reload of the filter's paramers. If you look at the filter's doc, this is explained:
You can either call If you don't know when to change, you can hook up the |
Beta Was this translation helpful? Give feedback.
10 replies
-
|
And thanks for the code example! |
Beta Was this translation helpful? Give feedback.
-
When I change the function like this, it prints the correct values in the terminal, but the text over the video is an empty string. --- a/main.liq
+++ b/main.liq
@@ -15,7 +15,9 @@ l = single("/tmp/test/cover.jpeg")
nowplaying = ref("")
a.on_metadata(fun(m) -> begin
- nowplaying := '#{m["artist"]}\n------------------------\n"#{m["title"]}"'
+ title = m["title"]
+ print("nowplaying is set from #{string.quote(nowplaying())} to #{string.quote(title)}")
+ nowplaying := title
end)
def prepare_source(~now_playing, ~logo, ~audio, background_vid) =
@@ -46,7 +48,7 @@ def prepare_source(~now_playing, ~logo, ~audio, background_vid) =
x=np_x,
y=np_y,
graph=graph,
- now_playing,
+ {print("nowplaying is #{string.quote(now_playing())}"); now_playing()},
p1
)Log |
Beta Was this translation helpful? Give feedback.
-
|
Ok. In this case, I'd push the logging further:
One possibility is that the metadata change happens before the function is properly assigned. |
Beta Was this translation helpful? Give feedback.
-
Diff--- a/main.liq
+++ b/main.liq
@@ -15,7 +15,9 @@ l = single("/tmp/test/cover.jpeg")
nowplaying = ref("")
a.on_metadata(fun(m) -> begin
- nowplaying := '#{m["artist"]}\n------------------------\n"#{m["title"]}"'
+ title = m["title"]
+ print("Nowplaying setter, old nowplaying=#{string.quote(nowplaying())}, new nowplaying=#{string.quote(title)}")
+ nowplaying := title
end)
def prepare_source(~now_playing, ~logo, ~audio, background_vid) =
@@ -29,7 +31,7 @@ def prepare_source(~now_playing, ~logo, ~audio, background_vid) =
time_x = 75
time_y = 75
- on_frame = ref({()})
+ on_frame = ref({print("Dummy on_frame, nowplaying=#{string.quote(now_playing())}")})
vid = source.on_frame(
background_vid,
fun() -> begin
@@ -46,7 +48,7 @@ def prepare_source(~now_playing, ~logo, ~audio, background_vid) =
x=np_x,
y=np_y,
graph=graph,
- now_playing,
+ {print("Nowplaying getter, nowplaying=#{string.quote(now_playing())}"); now_playing()},
p1
)
@@ -60,7 +62,8 @@ def prepare_source(~now_playing, ~logo, ~audio, background_vid) =
p2
)
- on_frame := {p2.on_change(); p3.on_change()}
+ print("Assigning the new on_frame function.")
+ on_frame := {print("Final on_frame, nowplaying=#{string.quote(now_playing())}") p2.on_change(); p3.on_change()}
logo = ffmpeg.filter.video.input(graph, source.tracks(logo).video)
logo = ffmpeg.filter.scale(graph, logo, w="-1", h="178")
Log |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for that code snippet. It was immensely helpful. As for the video showing a blank string on the first song, that hasn't been an issue on my end. That may be due to Azuracast loading an intro music file upon radio startup. Then when the actual music starts it counts as the second item in the list and therefore properly displays. I do get the occasional flash of a negative number on the timer countdown during song transition, which may be from the metadata it is reading. I need to monitor that. |
Beta Was this translation helpful? Give feedback.
-
|
@vitoyucepi ERROR: CODE: I believe the issue is with the following parameter: When I remove the |
Beta Was this translation helpful? Give feedback.
6 replies
-
|
I have looked over that code, and it would work nicely on a liquidsoap only setup. It throws an error like this: |
Beta Was this translation helpful? Give feedback.
-
Of course, it's not implemented, but you can get all the necessary functions from As for the original question, I haven't configured the local environment to test your script yet. |
Beta Was this translation helpful? Give feedback.
-
|
@vitoyucepi Here is the current error: I do need to tweak things to get the layout and sizing right but here is the code I am working with: |
Beta Was this translation helpful? Give feedback.
-
|
@vitoyucepi @toots I am getting this error: |
Beta Was this translation helpful? Give feedback.
-
|
In the original example, the encoder is defined as follows enc =
%ffmpeg(
format = "mpegts",
%audio(codec = "aac", b = "192k"),
%video(codec = "libx264", preset = "ultrafast", g = 50)
)So you should use |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Describe the bug
There appears to be a bug in the video.add_text.ffmpeg.raw.filter() function, which correctly processes static text but generates incorrect output if the input is dynamic (such as changing metadata or a counter). I've included two lines of codes in one of my functions:
These output in the Liquidsoap log and show that the functions intially generating this data are running correctly. However, the issue arises after they are passed into video.add_text.ffmpeg.raw.filter().
To Reproduce
** Logs **
Expected behavior
This code should generate a video stream that shows the currently playing song metadata, a countdown until the next song is played, and a logo overlay. Instead, the code outputs no metadata, the number 00 instead of a countdown, but the logo is displayed correctly.
You can access the livestream to see the output at https://www.youtube.com/watch?v=HPhxFR1Y4MY
Version details
Liquidsoap 2.2.2
Install method
AzuraCast - v0.19.3 Stable - Docker - PHP 8.2
Beta Was this translation helpful? Give feedback.
All reactions