Get duration file

[livesbetter]

Liquidsoap 2.2.1
Ubuntu 22

I´m getting track duration and returns:

track_length = int_of_float(request.duration(new.metadata["filename"]))

Error 5: this value has type
  _?
but it should be a subtype of
  float

Line:
track_length = int_of_float(request.duration(new.metadata.filename))

[vitoyucepi]

Hi @livesbetter,
The request.duration function returns a nullable value. If you are migrating from the previous versions, then check out the migration manual at https://www.liquidsoap.info/doc-dev/migrating.html#other-breaking-changes.

To get the value of the nullable value, you have to use null.get(), but be aware of the exception!

track_length = null.get(request.duration(new.metadata["filename"]))

[livesbetter]

Hello @vitoyucepi

Thanks for help, but i have problem cause i´m using in custom fade

[vitoyucepi]

Would you kindly post a source code of your liquidsoap script.
You could use the following construction to post the source of type liquidsoap.

```ruby
# Source code here
```

If you'd like to post the logs use this one instead

```
2023-01-01T01:01:01 [CORE] I'm the log
```

[livesbetter]

  def f(old, new) = 
		track_length = null.get(request.duration(new.metadata["filename"]))
		track_length2 = null.get(request.duration(old.metadata["filename"]))
		if track_length > 20.0 then  
		  if track_length2 > 20.0 then
			add(normalize = false, [fade.in(duration = 4.0, new.source), fade.out(duration = 4.0, old.source), ])
		  else        if track_length2 < 0.0 then  
			add(normalize = false, [fade.in(duration = 4.0, new.source), fade.out(duration = 4.0, old.source), ])
			else 
				sequence([old.source,new.source])
			end
		  end
		else    
		  if track_length < 0.0 then    
			add(normalize = false, [fade.in(duration = 4.0, new.source), fade.out(duration = 4.0, old.source), ])
		  else 
			  sequence([old.source,new.source])
		  end
		end
	 end
 cross(f,s)
end

radio = custom_fade(radio)


Logs
`[clock.main:2] Source 8000 failed while streaming: Clock_conflict: At position: at audio.liq, line 53, char 2-98, a source cannot belong to two clocks (cross.2.child[], cross.child[cue_cut.4.child[],cue_cut.3.child[],cue_cut.2.child[],cue_cut.child[]])!
2023/10/25 14:32:34 [clock.main:2] Raised at Source.unify in file "src/core/source.ml", line 215, characters 10-94
2023/10/25 14:32:34 [clock.main:2] Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
2023/10/25 14:32:34 [clock.main:2] Called from Child_support.base#set_clock in file "src/core/tools/child_support.ml", line 67, characters 6-99
2023/10/25 14:32:34 [clock.main:2] Called from CamlinternalOO.iter_f in file "camlinternalOO.ml", line 371, characters 12-17
2023/10/25 14:32:34 [clock.main:2] Called from CamlinternalOO.run_initializers_opt in file "camlinternalOO.ml", line 381, characters 24-40
2023/10/25 14:32:34 [clock.main:2] Called from Lang_source.add_operator.f in file "src/core/lang_source.ml", line 431, characters 39-44
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 174, characters 8-12
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 341, characters 10-43
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 353, characters 10-38
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 341, characters 10-43
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 353, characters 10-38
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 174, characters 8-12
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 341, characters 10-43
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 353, characters 10-38
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 174, characters 8-12
2023/10/25 14:32:34 [clock.main:2] Called from Stdlib__Fun.protect in file "fun.ml", line 33, characters 8-15
2023/10/25 14:32:34 [clock.main:2] Re-raised at Stdlib__Fun.protect in file "fun.ml", line 38, characters 6-52
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 174, characters 8-12
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 341, characters 10-43
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 353, characters 10-38
2023/10/25 14:32:34 [clock.main:2] Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 174, characters 8-12
2023/10/25 14:32:34 [clock.main:2] Called from Stdlib__Fun.protect in file "fun.ml", line 33, characters 8-15
2023/10/25 14:32:34 [clock.main:2] Re-raised at Stdlib__Fun.protect in file "fun.ml", line 38, characters 6-52
2023/10/25 14:32:34 [clock.main:2] Called from Cross.cross#create_transition.(fun).f in file "src/core/operators/cross.ml", line 355, characters 29-59
2023/10/25 14:32:34 [clock.main:2] Called from Stdlib__Fun.protect in file "fun.ml", line 33, characters 8-15
2023/10/25 14:32:34 [clock.main:2] Re-raised at Stdlib__Fun.protect in file "fun.ml", line 38, characters 6-52
2023/10/25 14:32:34 [clock.main:2] Called from Cross.cross#create_transition in file "src/core/operators/cross.ml", line 316, characters 8-1023
2023/10/25 14:32:34 [clock.main:2] Called from Cross.cross#get_frame in file "src/core/operators/cross.ml", line 209, characters 12-34
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from Switch.switch#get_frame in file "src/core/operators/switch.ml", line 242, characters 14-39
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from On_frame.on_frame#get_frame in file "src/core/operators/on_frame.ml", line 35, characters 6-14
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from Insert_metadata.insert_metadata#get_frame in file "src/core/operators/insert_metadata.ml", line 75, characters 8-22
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from Rms_smooth.rms#get_frame in file "src/core/operators/rms_smooth.ml", line 44, characters 6-20
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from On_frame.on_frame#get_frame in file "src/core/operators/on_frame.ml", line 35, characters 6-14
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from On_track.on_track#get_frame in file "src/core/operators/on_track.ml", line 37, characters 6-14
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from Delay_line.delay#get_frame in file "src/core/operators/delay_line.ml", line 60, characters 6-20
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 782, characters 12-44
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#feed_fields in file "src/core/operators/muxer.ml", line 117, characters 8-22
2023/10/25 14:32:34 [clock.main:2] Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#feed in file "src/core/operators/muxer.ml", line 134, characters 8-51
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#get_frame in file "src/core/operators/muxer.ml", line 156, characters 6-31
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 782, characters 12-44
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#feed_fields in file "src/core/operators/muxer.ml", line 117, characters 8-22
2023/10/25 14:32:34 [clock.main:2] Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#feed in file "src/core/operators/muxer.ml", line 134, characters 8-51
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#get_frame in file "src/core/operators/muxer.ml", line 156, characters 6-31
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from Switch.switch#get_frame in file "src/core/operators/switch.ml", line 242, characters 14-39
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 782, characters 12-44
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#feed_fields in file "src/core/operators/muxer.ml", line 117, characters 8-22
2023/10/25 14:32:34 [clock.main:2] Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#feed in file "src/core/operators/muxer.ml", line 134, characters 8-51
2023/10/25 14:32:34 [clock.main:2] Called from Muxer.muxer#get_frame in file "src/core/operators/muxer.ml", line 156, characters 6-31
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#instrumented_get_frame in file "src/core/source.ml", line 654, characters 6-24
2023/10/25 14:32:34 [clock.main:2] Called from Source.operator#get in file "src/core/source.ml", line 765, characters 10-41
2023/10/25 14:32:34 [clock.main:2] Called from Output.output#output in file "src/core/outputs/output.ml", line 173, characters 10-30
2023/10/25 14:32:34 [clock.main:2] Called from Clock.MkClock.clock#end_tick.(fun) in file "src/core/clock.ml", line 318, characters 16-24
2023/10/25 14:32:34 [clock.main:2]
2023/10/25 14:32:34 [8000:3] Closing connection...
`

[vitoyucepi]

I don't see any problems with this function. Correct me if I did something wrong.

def f(old, new) =  
  track_length_new = null.get(request.duration(new.metadata["filename"]))
  track_length_old = null.get(request.duration(old.metadata["filename"]))
  if track_length_new > 20. then
    if track_length_old > 20. then
      add(normalize = false, [fade.in(duration = 4., new.source), fade.out(duration = 4., old.source), ])
    elsif track_length_old < 0.0 then          
      add(normalize = false, [fade.in(duration = 4., new.source), fade.out(duration = 4., old.source), ])
    else 
      sequence([old.source,new.source])
    end
  elsif track_length_new < 0. then     
    add(normalize = false, [fade.in(duration = 4., new.source), fade.out(duration = 4., old.source), ])
  else 
    sequence([old.source,new.source])
  end 
end
cross(f,s)

Here's my proposed refactor for the function, but I'm not sure if it aligns with the desired behavior.

def f(old, new) =
  old_duration = source.duration(old.source)
  new_duration = source.duration(new.source)
  if old_duration > 20. or new_duration > 20. then
    add([fade.out(old.source, duration=4.), fade.in(new.source, duration=4.)])
  else
    sequence([old.source, new.source])
  end
end

cross(f, s)

[livesbetter]

Yes, but i get error...

Source 8000 failed while streaming: Lang.Runtime_error { kind: "not_found", msg: "no default value for null.get", pos: [at /home/liquidsoap.liq, line 160, char 21-73, at null.liq, line 12 char 2 - line 14 char 17, at null.liq, line 13, char 5-77, at null.liq, line 13, char 16-77, at null.liq, line 13, char 16-77] }!

[vitoyucepi]

Sorry, but I could not see the line numbers and the source code.
It would be helpful if you could post the full code of the script so I can test it locally.
Please use the formatting for the source code.

[livesbetter]

I have a very complete code with exclusive functions, I can pass it on if you use liquidsoap slack privately, to avoid copies from other users.