Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overexplanation of Macro #57

Open
Hsing-YngLouh opened this issue Apr 10, 2024 · 0 comments
Open

Overexplanation of Macro #57

Hsing-YngLouh opened this issue Apr 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Hsing-YngLouh
Copy link

Describe the bug
With code generation not being supported as of yet, I am not sure if this also applies to the "Explain" function, but when highlighting a macro statement that is being used to declare a function (i.e. %macro inflate_data(factors=, out_lib=, filter_lib=,dx4_flg=N);), the "Explain" feature is making guesses on the macro and parameters' purposes based on name. As seen in the screenshot below, copilot is first saying that the "dx4_flg" parameter is specifying if the data contains a fourth dimension. In the second explanation (just asking copilot to explain the same code again), it is saying that the "dx4_flg" parameter is an indication of if a fourth factor should be included in the inflation. From a user standpoint, this was just a random macro statement I created, and theoretically, I wanted to use "dx4_flg" as a parameter to indicate whether or not the data should be inflated to be four times its original size which is not given in either of the explanations.

To Reproduce
Steps to reproduce the behavior:

  1. In an empty sas file, type "%macro inflate_data(factors=, out_lib=, filter_lib=,dx4_flg=N);"
  2. Highlight the statement from above and ask copilot to explain it.
  3. Highlight the statement from step 1 and ask copilot to explain it again.

Expected behavior
Though some of the explanations contain a note at the bottom specifying that there is not enough detail to fully explain the macro, this disclaimer should be given more consistently when details are unclear (especially only if no lines of code for the macro are provided) and also specified so that it includes the explanations of the parameter given in the disclaimer. The explanation should not infer too much from the function or parameter names to provide explanations, especially in cases where the user is not someone who uses informative function/parameter names. For example, the explanation could identify the "dx4_flg" parameter as a "Y" or "N", but it should not provide further details on what the flag means given the limited information and context provided.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: PC
  • Version: v0.0.2

Reporter's Organization
SAS

Additional context
Add any other context about the problem here.

@Hsing-YngLouh Hsing-YngLouh added the bug Something isn't working label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants