Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack issues #815

Open
medjedovicm opened this issue Jun 22, 2023 · 0 comments
Open

Webpack issues #815

medjedovicm opened this issue Jun 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@medjedovicm
Copy link
Member

1st issue: Bare import for @sasjs/utils doesn't work

Currently, if in any place in adapter @sasjs/utils import is used as bare, the adapter Is unable even to load. (eg. in Data Controller)
The workaround we are using is deep imports @sasjs/utils/some/path.
That is a huge issue since any external contributor would have problems and would not even know why. Even @YuryShkoda lost too much time on it, just because it is unclear what the issue is.

2nd issue: When the adapter is built with development mode, it fails to load

Very similar to the above issue, the error happens because of the @sasjs/utils package, but from the error, it is uncertain as to why. Most likely it has to do with something about how @sasjs/utils is bundled.

How to reproduce webpack development mode issue

image

  • Then run npm run package:lib
  • Install tarball to the client (eg. DC)
@YuryShkoda YuryShkoda added the bug Something isn't working label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants