Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FourierLayer() has instance methods that do not act on the instance. #21

Open
sascha-kirch opened this issue Nov 4, 2023 · 0 comments
Labels
refactor indicates that s.th. should be refactored.

Comments

@sascha-kirch
Copy link
Owner

FourierLayer() has methods like _matrix_product() or _change_to_channel_first() that do not require the instance of the class.
They have been simply put into a base class that is then inherited from.
So it is actually not really a base class but rather a collection of functions used in the child classes.

They could be turned into static methods.

@sascha-kirch sascha-kirch added the refactor indicates that s.th. should be refactored. label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor indicates that s.th. should be refactored.
Projects
None yet
Development

No branches or pull requests

1 participant